[SPARK-58068][PYTHON][TESTS] Move test_import_spark to pyspark_install module#57164
Closed
gaogaotiantian wants to merge 1 commit into
Closed
[SPARK-58068][PYTHON][TESTS] Move test_import_spark to pyspark_install module#57164gaogaotiantian wants to merge 1 commit into
test_import_spark to pyspark_install module#57164gaogaotiantian wants to merge 1 commit into
Conversation
dongjoon-hyun
approved these changes
Jul 9, 2026
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
+1, LGTM. Thank you, @gaogaotiantian .
So, this will remove the on-going test_import_spark failures?
dongjoon-hyun
changed the title
test_import_spark to pyspark_install module
Contributor
Author
No, the fix is proposed in #57163 . We will try to merge that soon after sorting out the issues with the PR. This PR fixes the issue why we did not catch it in pre-merge check. |
Member
|
Oh, got it! |
Member
|
Merged to master and branch-4.x. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Jul 9, 2026
…all` module ### What changes were proposed in this pull request? Move `test_import_spark` to `pyspark_install` module from `pyspark_core`. ### Why are the changes needed? 1. `test_import_spark` should be triggered for any changes in pyspark, including streaming/ml etc. `test_install` currently does that. 2. `test_install` is cheap because it is not executed in post-merge. It would be executed in scheduled CI only. We failed to catch the import issue from #56786 because the test did not run. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #57164 from gaogaotiantian/move-import-check. Authored-by: Tian Gao <gaogaotiantian@hotmail.com> Signed-off-by: Hyukjin Kwon <hyukjin.kwon@databricks.com> (cherry picked from commit 1935ee0) Signed-off-by: Hyukjin Kwon <hyukjin.kwon@databricks.com>
Member
|
Just for a bit of context, I am trying to let Spark 4.3 ready to release on time so being obsessed in CI :-) |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Move
test_import_sparktopyspark_installmodule frompyspark_core.Why are the changes needed?
test_import_sparkshould be triggered for any changes in pyspark, including streaming/ml etc.test_installcurrently does that.test_installis cheap because it is not executed in post-merge. It would be executed in scheduled CI only.We failed to catch the import issue from #56786 because the test did not run.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI.
Was this patch authored or co-authored using generative AI tooling?
No.