[SPARK-58074][INFRA] Mask PYPI_API_TOKEN in dry-run mode of release.yml#57170
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
[SPARK-58074][INFRA] Mask PYPI_API_TOKEN in dry-run mode of release.yml#57170dongjoon-hyun wants to merge 1 commit into
PYPI_API_TOKEN in dry-run mode of release.yml#57170dongjoon-hyun wants to merge 1 commit into
Conversation
Member
Author
|
Thank you, @HyukjinKwon ! 😄 |
dongjoon-hyun
added a commit
that referenced
this pull request
Jul 9, 2026
…e.yml` ### What changes were proposed in this pull request? This PR aims to mask `PYPI_API_TOKEN` with a `"not_used"` placeholder in the dry-run mode of `release.yml`, like the other secrets. ### Why are the changes needed? In dry-run mode, all other secrets are replaced with placeholders, but `PYPI_API_TOKEN` was missing from the list. So, the real token was propagated to the release scripts and the Docker container environment although dry runs never use it. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Fable 5 Closes #57170 from dongjoon-hyun/SPARK-58074. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 1047560) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to mask
PYPI_API_TOKENwith a"not_used"placeholder in the dry-run mode ofrelease.yml, like the other secrets.Why are the changes needed?
In dry-run mode, all other secrets are replaced with placeholders, but
PYPI_API_TOKENwas missing from the list. So, the real token was propagated to the release scripts and the Docker container environment although dry runs never use it.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual review.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Fable 5