[SPARK-58075][INFRA] Add --rm to docker run in do-release-docker.sh#57171
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
[SPARK-58075][INFRA] Add --rm to docker run in do-release-docker.sh#57171dongjoon-hyun wants to merge 1 commit into
--rm to docker run in do-release-docker.sh#57171dongjoon-hyun wants to merge 1 commit into
Conversation
HyukjinKwon
approved these changes
Jul 9, 2026
Member
Author
|
Thank you, @HyukjinKwon . |
dongjoon-hyun
added a commit
that referenced
this pull request
Jul 9, 2026
### What changes were proposed in this pull request? This PR aims to add the `--rm` flag to the `docker run` invocation in `dev/create-release/do-release-docker.sh` so that the release container is removed automatically when it exits. ### Why are the changes needed? The container is started with `--env-file`, which injects secrets such as `ASF_PASSWORD`, `GPG_PASSPHRASE`, `PYPI_API_TOKEN`, and `ASF_NEXUS_TOKEN`. Without `--rm`, the stopped container remains on the host and the secrets can be read in plain text via `docker inspect`. This is safe because nothing references the container after it exits, and all outputs are written to the host via the `$WORKDIR` volume mount. ### Does this PR introduce _any_ user-facing change? No. This is a release script which is used by release managers. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Fable 5 Closes #57171 from dongjoon-hyun/SPARK-58075. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 0ae5d86) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add the
--rmflag to thedocker runinvocation indev/create-release/do-release-docker.shso that the release container is removed automatically when it exits.Why are the changes needed?
The container is started with
--env-file, which injects secrets such asASF_PASSWORD,GPG_PASSPHRASE,PYPI_API_TOKEN, andASF_NEXUS_TOKEN. Without--rm, the stopped container remains on the host and the secrets can be read in plain text viadocker inspect.This is safe because nothing references the container after it exits, and all outputs are written to the host via the
$WORKDIRvolume mount.Does this PR introduce any user-facing change?
No. This is a release script which is used by release managers.
How was this patch tested?
Manual review.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Fable 5