[SPARK-58152][K8S] Avoid logging credentials in Kubernetes client config debug log#57281
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
[SPARK-58152][K8S] Avoid logging credentials in Kubernetes client config debug log#57281dongjoon-hyun wants to merge 1 commit into
dongjoon-hyun wants to merge 1 commit into
Conversation
Member
Author
|
Could you review this PR, @peter-toth ? |
peter-toth
approved these changes
Jul 15, 2026
Member
Author
|
Thank you, @peter-toth ! |
dongjoon-hyun
added a commit
that referenced
this pull request
Jul 15, 2026
…fig debug log ### What changes were proposed in this pull request? Log only non-sensitive fields (`masterUrl`, `namespace`, `apiVersion`, `requestTimeout`, `connectionTimeout`, `trustCerts`) in the DEBUG log line of `SparkKubernetesClientFactory.createKubernetesClient`, instead of serializing the entire fabric8 `Config` object with a plain `ObjectMapper`. ### Why are the changes needed? `Config` holds the API server credentials, and a plain `ObjectMapper` applies no masking, so the previous line logged `oauthToken`, `clientKeyData`, `caCertData`, `clientCertData`, the basic-auth password, and the truststore password in cleartext. (`oauthToken` is annotated `JsonIgnore`, but `JsonIgnoreProperties(allowGetters = true)` on the class re-enables it via its getter.) `createKubernetesClient` runs on both the submission client and the driver, and driver logs are commonly collected and archived. ### Does this PR introduce _any_ user-facing change? No. DEBUG log content only. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Fable 5 Closes #57281 from dongjoon-hyun/SPARK-58152. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit a4dc5d9) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Jul 15, 2026
…fig debug log ### What changes were proposed in this pull request? Log only non-sensitive fields (`masterUrl`, `namespace`, `apiVersion`, `requestTimeout`, `connectionTimeout`, `trustCerts`) in the DEBUG log line of `SparkKubernetesClientFactory.createKubernetesClient`, instead of serializing the entire fabric8 `Config` object with a plain `ObjectMapper`. ### Why are the changes needed? `Config` holds the API server credentials, and a plain `ObjectMapper` applies no masking, so the previous line logged `oauthToken`, `clientKeyData`, `caCertData`, `clientCertData`, the basic-auth password, and the truststore password in cleartext. (`oauthToken` is annotated `JsonIgnore`, but `JsonIgnoreProperties(allowGetters = true)` on the class re-enables it via its getter.) `createKubernetesClient` runs on both the submission client and the driver, and driver logs are commonly collected and archived. ### Does this PR introduce _any_ user-facing change? No. DEBUG log content only. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Fable 5 Closes #57281 from dongjoon-hyun/SPARK-58152. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit a4dc5d9) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Jul 15, 2026
…fig debug log ### What changes were proposed in this pull request? Log only non-sensitive fields (`masterUrl`, `namespace`, `apiVersion`, `requestTimeout`, `connectionTimeout`, `trustCerts`) in the DEBUG log line of `SparkKubernetesClientFactory.createKubernetesClient`, instead of serializing the entire fabric8 `Config` object with a plain `ObjectMapper`. ### Why are the changes needed? `Config` holds the API server credentials, and a plain `ObjectMapper` applies no masking, so the previous line logged `oauthToken`, `clientKeyData`, `caCertData`, `clientCertData`, the basic-auth password, and the truststore password in cleartext. (`oauthToken` is annotated `JsonIgnore`, but `JsonIgnoreProperties(allowGetters = true)` on the class re-enables it via its getter.) `createKubernetesClient` runs on both the submission client and the driver, and driver logs are commonly collected and archived. ### Does this PR introduce _any_ user-facing change? No. DEBUG log content only. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Fable 5 Closes #57281 from dongjoon-hyun/SPARK-58152. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit a4dc5d9) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Jul 15, 2026
…fig debug log Log only non-sensitive fields (`masterUrl`, `namespace`, `apiVersion`, `requestTimeout`, `connectionTimeout`, `trustCerts`) in the DEBUG log line of `SparkKubernetesClientFactory.createKubernetesClient`, instead of serializing the entire fabric8 `Config` object with a plain `ObjectMapper`. `Config` holds the API server credentials, and a plain `ObjectMapper` applies no masking, so the previous line logged `oauthToken`, `clientKeyData`, `caCertData`, `clientCertData`, the basic-auth password, and the truststore password in cleartext. (`oauthToken` is annotated `JsonIgnore`, but `JsonIgnoreProperties(allowGetters = true)` on the class re-enables it via its getter.) `createKubernetesClient` runs on both the submission client and the driver, and driver logs are commonly collected and archived. No. DEBUG log content only. Pass the CIs. Generated-by: Claude Fable 5 Closes #57281 from dongjoon-hyun/SPARK-58152. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit a4dc5d9) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Jul 15, 2026
…fig debug log Log only non-sensitive fields (`masterUrl`, `namespace`, `apiVersion`, `requestTimeout`, `connectionTimeout`, `trustCerts`) in the DEBUG log line of `SparkKubernetesClientFactory.createKubernetesClient`, instead of serializing the entire fabric8 `Config` object with a plain `ObjectMapper`. `Config` holds the API server credentials, and a plain `ObjectMapper` applies no masking, so the previous line logged `oauthToken`, `clientKeyData`, `caCertData`, `clientCertData`, the basic-auth password, and the truststore password in cleartext. (`oauthToken` is annotated `JsonIgnore`, but `JsonIgnoreProperties(allowGetters = true)` on the class re-enables it via its getter.) `createKubernetesClient` runs on both the submission client and the driver, and driver logs are commonly collected and archived. No. DEBUG log content only. Pass the CIs. Generated-by: Claude Fable 5 Closes #57281 from dongjoon-hyun/SPARK-58152. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit a4dc5d9) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Log only non-sensitive fields (
masterUrl,namespace,apiVersion,requestTimeout,connectionTimeout,trustCerts) in the DEBUG log line ofSparkKubernetesClientFactory.createKubernetesClient, instead of serializing the entire fabric8Configobject with a plainObjectMapper.Why are the changes needed?
Configholds the API server credentials, and a plainObjectMapperapplies no masking, so theprevious line logged
oauthToken,clientKeyData,caCertData,clientCertData, the basic-authpassword, and the truststore password in cleartext. (
oauthTokenis annotated@JsonIgnore, but@JsonIgnoreProperties(allowGetters = true)on the class re-enables it via its getter.)createKubernetesClientruns on both the submission client and the driver, and driver logs arecommonly collected and archived.
Does this PR introduce any user-facing change?
No. DEBUG log content only.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Fable 5