[SPARK-58095][SQL] approx_top_k_combine throws scala.MatchError on empty input#57289
Draft
jiwen624 wants to merge 2 commits into
Draft
[SPARK-58095][SQL] approx_top_k_combine throws scala.MatchError on empty input#57289jiwen624 wants to merge 2 commits into
jiwen624 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix the MatchError on empty input with changes below:
uncheckedItemDataType) when no input sketch resolved it, in bothevalandserialize.maxItemsTrackedis still the internalVOIDsentinel (-1); resolve it to the default inevalonly (a partial buffer must keepVOIDfor the final merge), so the empty output sketch carries a valid size that downstream functions such asapprox_top_k_estimateaccept.Why are the changes needed?
The query aborts with an internal error instead of returning an empty result, unlike the sibling functions (
approx_top_k,approx_top_k_accumulate,approx_top_k_estimate) which handle empty input correctly:Does this PR introduce any user-facing change?
Yes. Fixed an query failing issue when the input is empty.
How was this patch tested?
Added UT case
Was this patch authored or co-authored using generative AI tooling?
Yes.