[SPARK-58178][SQL][TEST][3.5] Expected size needs to increase#57358
Open
holdenk wants to merge 1 commit into
Open
[SPARK-58178][SQL][TEST][3.5] Expected size needs to increase#57358holdenk wants to merge 1 commit into
holdenk wants to merge 1 commit into
Conversation
…har) Co-authored-by: Holden Karau <holden@pigscanfly.ca>
holdenk
changed the title
pan3793
reviewed
Jul 21, 2026
| sql(s"INSERT INTO $tblName VALUES (1, 'a', '2019-12-13')") | ||
|
|
||
| val expectedSize = 657 | ||
| val expectedSize = 658 |
Member
There was a problem hiding this comment.
I guess due to 3.5.9 => 3.5.10?
pan3793
approved these changes
Jul 21, 2026
uros-b
reviewed
Jul 21, 2026
| Seq(tbl, ext_tbl).foreach { tblName => | ||
| sql(s"INSERT INTO $tblName VALUES (1, 'a', '2019-12-13')") | ||
|
|
||
| val expectedSize = 657 |
Member
There was a problem hiding this comment.
The fix again hardcodes another magic byte count (658), preserving the fragility that caused this issue.
It will fail again on any future version-string-length change or Parquet bump on 3.5.
A better fix (SPARK-53422) is already merged on master. Should we consider cherry picking it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Increases expected string size.
Why are the changes needed?
Version string embedded in results
Does this PR introduce any user-facing change?
Test only
How was this patch tested?
Previous failing test now passes
Was this patch authored or co-authored using generative AI tooling?
no