[SPARK-58243][PYTHON] Remove unused ApplyInPandasWithStateSerializer#57409
Closed
Yicong-Huang wants to merge 1 commit into
Closed
[SPARK-58243][PYTHON] Remove unused ApplyInPandasWithStateSerializer#57409Yicong-Huang wants to merge 1 commit into
Yicong-Huang wants to merge 1 commit into
Conversation
HyukjinKwon
approved these changes
Jul 21, 2026
uros-b
approved these changes
Jul 22, 2026
Member
|
Thank you @Yicong-Huang! |
Yicong-Huang
added a commit
that referenced
this pull request
Jul 22, 2026
### What changes were proposed in this pull request? Delete the now-unused `ApplyInPandasWithStateSerializer`. After SPARK-58189 refactored `SQL_GROUPED_MAP_PANDAS_UDF_WITH_STATE` to extract its logic into `read_udfs()` (state management and Pandas conversion moved into the wrapper) and use `ArrowStreamSerializer` directly, this class is dead code. Imports left unused by the deletion (`CPickleSerializer`, `to_arrow_type`, `StringType`, `BinaryType`, `LongType`, `IntegerType`) are removed, and a stale class-name reference in a benchmark docstring is reworded. Part of SPARK-55384. ### Why are the changes needed? The class is no longer referenced anywhere; removing it and its dead imports keeps `serializers.py` lean. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. No behavior change. `pyspark.sql.tests.pandas.test_pandas_grouped_map_with_state` passes. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #57409 from Yicong-Huang/SPARK-58243. Authored-by: Yicong Huang <17627829+Yicong-Huang@users.noreply.github.com> Signed-off-by: Yicong-Huang <17627829+Yicong-Huang@users.noreply.github.com> (cherry picked from commit 600e361) Signed-off-by: Yicong-Huang <17627829+Yicong-Huang@users.noreply.github.com>
Contributor
Author
Contributor
Author
|
Thanks @HyukjinKwon @uros-b ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Delete the now-unused
ApplyInPandasWithStateSerializer. After SPARK-58189 refactoredSQL_GROUPED_MAP_PANDAS_UDF_WITH_STATEto extract its logic intoread_udfs()(state management and Pandas conversion moved into the wrapper) and useArrowStreamSerializerdirectly, this class is dead code. Imports left unused by the deletion (CPickleSerializer,to_arrow_type,StringType,BinaryType,LongType,IntegerType) are removed, and a stale class-name reference in a benchmark docstring is reworded.Part of SPARK-55384.
Why are the changes needed?
The class is no longer referenced anywhere; removing it and its dead imports keeps
serializers.pylean.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests. No behavior change.
pyspark.sql.tests.pandas.test_pandas_grouped_map_with_statepasses.Was this patch authored or co-authored using generative AI tooling?
No.