[SPARK-58335][K8S][TESTS] Add SparkKubernetesClientFactorySuite#57513
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
[SPARK-58335][K8S][TESTS] Add SparkKubernetesClientFactorySuite#57513dongjoon-hyun wants to merge 1 commit into
SparkKubernetesClientFactorySuite#57513dongjoon-hyun wants to merge 1 commit into
Conversation
uros-b
approved these changes
Jul 24, 2026
Member
|
Thank you @dongjoon-hyun! |
Member
Author
|
Thank you, @uros-b ! |
dongjoon-hyun
added a commit
that referenced
this pull request
Jul 25, 2026
### What changes were proposed in this pull request? This PR aims to add `SparkKubernetesClientFactorySuite` to test `SparkKubernetesClientFactory.createKubernetesClient`, covering the patterns of its production call sites: master URL/namespace/API version propagation, per-`ClientType` timeouts, OAuth token and TLS file handling under all auth conf prefixes, the default service account CA cert fallback, `spark.kubernetes.trust.certificates`, the retry backoff limit system property, and `spark.kubernetes.context` selection. ### Why are the changes needed? `SparkKubernetesClientFactory` is a `Stable` `DeveloperApi` but had no test coverage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs with the newly added test suite. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Fable 5 Closes #57513 from dongjoon-hyun/SPARK-58335. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 4a5bb95) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Jul 25, 2026
### What changes were proposed in this pull request? This PR aims to add `SparkKubernetesClientFactorySuite` to test `SparkKubernetesClientFactory.createKubernetesClient`, covering the patterns of its production call sites: master URL/namespace/API version propagation, per-`ClientType` timeouts, OAuth token and TLS file handling under all auth conf prefixes, the default service account CA cert fallback, `spark.kubernetes.trust.certificates`, the retry backoff limit system property, and `spark.kubernetes.context` selection. ### Why are the changes needed? `SparkKubernetesClientFactory` is a `Stable` `DeveloperApi` but had no test coverage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs with the newly added test suite. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Fable 5 Closes #57513 from dongjoon-hyun/SPARK-58335. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 4a5bb95) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Jul 25, 2026
### What changes were proposed in this pull request? This PR aims to add `SparkKubernetesClientFactorySuite` to test `SparkKubernetesClientFactory.createKubernetesClient`, covering the patterns of its production call sites: master URL/namespace/API version propagation, per-`ClientType` timeouts, OAuth token and TLS file handling under all auth conf prefixes, the default service account CA cert fallback, `spark.kubernetes.trust.certificates`, the retry backoff limit system property, and `spark.kubernetes.context` selection. ### Why are the changes needed? `SparkKubernetesClientFactory` is a `Stable` `DeveloperApi` but had no test coverage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs with the newly added test suite. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Fable 5 Closes #57513 from dongjoon-hyun/SPARK-58335. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 4a5bb95) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Jul 25, 2026
This PR aims to add `SparkKubernetesClientFactorySuite` to test `SparkKubernetesClientFactory.createKubernetesClient`, covering the patterns of its production call sites: master URL/namespace/API version propagation, per-`ClientType` timeouts, OAuth token and TLS file handling under all auth conf prefixes, the default service account CA cert fallback, `spark.kubernetes.trust.certificates`, the retry backoff limit system property, and `spark.kubernetes.context` selection. `SparkKubernetesClientFactory` is a `Stable` `DeveloperApi` but had no test coverage. No. Pass the CIs with the newly added test suite. Generated-by: Claude Fable 5 Closes #57513 from dongjoon-hyun/SPARK-58335. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 4a5bb95) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add
SparkKubernetesClientFactorySuiteto testSparkKubernetesClientFactory.createKubernetesClient, covering the patterns of its production call sites: master URL/namespace/API version propagation, per-ClientTypetimeouts, OAuth token and TLS file handling under all auth conf prefixes, the default service account CA cert fallback,spark.kubernetes.trust.certificates, the retry backoff limit system property, andspark.kubernetes.contextselection.Why are the changes needed?
SparkKubernetesClientFactoryis a@Stable@DeveloperApibut had no test coverage.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs with the newly added test suite.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Fable 5