[SPARK-58354][PYTHON] Remove unused ArrowStreamPandasSerializer base class - #57544
Closed
Yicong-Huang wants to merge 1 commit into
Closed
[SPARK-58354][PYTHON] Remove unused ArrowStreamPandasSerializer base class#57544Yicong-Huang wants to merge 1 commit into
Yicong-Huang wants to merge 1 commit into
Conversation
HyukjinKwon
approved these changes
Jul 26, 2026
uros-b
approved these changes
Jul 26, 2026
Member
|
Thank you @Yicong-Huang! |
zhengruifeng
approved these changes
Jul 27, 2026
Yicong-Huang
added a commit
that referenced
this pull request
Jul 27, 2026
…class ### What changes were proposed in this pull request? Remove the unused `ArrowStreamPandasSerializer` base class. After all Pandas UDF serializer subclasses were removed (`ArrowStreamPandasUDFSerializer`, `GroupPandasUDFSerializer`, `ArrowStreamAggPandasUDFSerializer`, `ApplyInPandasWithStateSerializer`, `CogroupPandasUDFSerializer`, `TransformWithStateInPandasSerializer`), the base class became an orphan with no subclasses, no instantiations, and no other references anywhere in the Python tree. This also drops the now-orphaned `_normalize_packed` helper (only used by that class) and the imports that are no longer needed. ### Why are the changes needed? Dead code cleanup. The class and its sole helper are unreachable. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. No behavior change. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #57544 from Yicong-Huang/SPARK-58354. Authored-by: Yicong Huang <17627829+Yicong-Huang@users.noreply.github.com> Signed-off-by: Yicong Huang <17627829+Yicong-Huang@users.noreply.github.com> (cherry picked from commit e8d5e4a) Signed-off-by: Yicong Huang <17627829+Yicong-Huang@users.noreply.github.com>
Contributor
Author
Contributor
Author
|
Thanks @HyukjinKwon @zhengruifeng @uros-b , I've merged the PR. that's the last serializer to remove. we can now declare serializer refactoring completed! We are down from 24 serializers to only 4 now. The main remaining ones are |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove the unused
ArrowStreamPandasSerializerbase class. After all Pandas UDF serializer subclasses were removed (ArrowStreamPandasUDFSerializer,GroupPandasUDFSerializer,ArrowStreamAggPandasUDFSerializer,ApplyInPandasWithStateSerializer,CogroupPandasUDFSerializer,TransformWithStateInPandasSerializer), the base class became an orphan with no subclasses, no instantiations, and no other references anywhere in the Python tree. This also drops the now-orphaned_normalize_packedhelper (only used by that class) and the imports that are no longer needed.Why are the changes needed?
Dead code cleanup. The class and its sole helper are unreachable.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests. No behavior change.
Was this patch authored or co-authored using generative AI tooling?
No.