[SPARK-58355][SS] Fix grammar in metadata log null-check message - #57546
Closed
uros-b wants to merge 1 commit into
Closed
[SPARK-58355][SS] Fix grammar in metadata log null-check message#57546uros-b wants to merge 1 commit into
uros-b wants to merge 1 commit into
Conversation
HyukjinKwon
approved these changes
Jul 26, 2026
uros-b
commented
Jul 26, 2026
uros-b
left a comment
uros-b
left a comment
Member
Author
There was a problem hiding this comment.
Thank you @HyukjinKwon! Waiting for CI
uros-b
added a commit
that referenced
this pull request
Jul 27, 2026
### What changes were proposed in this pull request? Fixes the grammar of the null-metadata `require(...)` message in `HDFSMetadataLog` and `AsyncOffsetSeqLog`: "'null' metadata cannot written to a metadata log" becomes "... cannot be written ...". ### Why are the changes needed? The message was missing the word "be". The sibling `AsyncCommitLog` already uses the correct phrasing, so this brings the two outliers in line. The message is a plain `require()` string, not part of the error-condition framework, so it is not golden-tested. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Message-text-only change; no behavior change. No tests needed. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8) Closes #57546 from uros-b/error-metadatalog-cannot-be-written. Lead-authored-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com> Co-authored-by: Uros Bojanic <uros.bojanic@databricks.com> Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com> (cherry picked from commit a663376) Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixes the grammar of the null-metadata
require(...)message inHDFSMetadataLogandAsyncOffsetSeqLog: "'null' metadata cannot written to a metadata log" becomes "... cannot be written ...".Why are the changes needed?
The message was missing the word "be". The sibling
AsyncCommitLogalready uses the correct phrasing, so this brings the two outliers in line. The message is a plainrequire()string, not part of the error-condition framework, so it is not golden-tested.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Message-text-only change; no behavior change. No tests needed.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)