[SPARK-58371][DOC] Update json gem version to 2.21.1 - #57565
Closed
LuciferYang wants to merge 1 commit into
Closed
Conversation
Upgrade the `json` gem from 2.12.2 to 2.21.1 in `docs/Gemfile.lock` to pick up the fix for GHSA-x2f5-4prf-w687 / CVE-2026-54696.
Contributor
Author
|
Merge Summary:
Posted by |
Contributor
Author
|
Thank you @dongjoon-hyun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR upgrades the
jsongem from 2.12.2 to 2.21.1 indocs/Gemfile.lock. It is a transitive dependency (pulled in byjekyll, which requiresjson (~> 2.6)), and 2.21.1 satisfies that constraint, so only the locked spec version changes.jsonhas no runtime dependencies, so no other lock entries change anddocs/Gemfiledoes not need to be touched.Why are the changes needed?
2.21.1 includes the fix for a security advisory that affects all versions in
>= 2.9.0, < 2.19.9:fbuffer_do_inc_capa()compared the requested size against the buffer's total capacity instead of its remaining capacity, soJSON.dump(obj, io)orJSON::State#generate(obj, io)could write past the buffer when serializing a string near 16 KB. Fixed in 2.19.9.Following the same pattern as SPARK-57633 (
concurrent-ruby1.3.7), this picks up the latest release rather than the minimum patched version.Does this PR introduce any user-facing change?
No. This only affects the documentation build toolchain.
How was this patch tested?
Manually verified in a scratch copy of
docs/Gemfileanddocs/Gemfile.lock:Lock resolution matches. Running
bundle lock --update=jsonproduces a lock file byte-identical to the hand-edited one, confirming 2.21.1 satisfies jekyll'sjson (~> 2.6)and that no other locked spec is affected.Frozen install succeeds.
BUNDLE_FROZEN=true bundle installinstalls all 36 gems without modifying the lock file, andbundle listreportsjson (2.21.1).The advisory's PoC no longer crashes:
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 5)