[SPARK-58502][SQL] Make in-limit SQL test deterministic - #57713
Open
vladimirg-db wants to merge 2 commits into
Open
[SPARK-58502][SQL] Make in-limit SQL test deterministic#57713vladimirg-db wants to merge 2 commits into
vladimirg-db wants to merge 2 commits into
Conversation
uros-b
approved these changes
Aug 3, 2026
Member
|
Thank you @vladimirg-db! Let's wait for CI |
vladimirg-db
force-pushed
the
make-in-limit-test-deterministic-4x
branch
from
August 3, 2026 11:57
d605423 to
deb9a30
Compare
vladimirg-db
commented
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add deterministic ordering to result-sensitive subqueries in in-limit.sql that combine IN or NOT IN with LIMIT or OFFSET. Regenerate the execution and analyzer golden files.
This is the branch-4.x-only version of #57696, requested in #57696 (comment) for Spark 4.3.0.
Why are the changes needed?
Without an ordering, LIMIT and OFFSET may select different membership values under different physical row orders, making the golden results flaky. Ordering by the projected membership column makes tied rows semantically equivalent.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite -- -z in-limit.sql"
The suite passed both while regenerating the golden files and in a verification rerun (2/2 tests each).
Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-5)