Skip to content

[SPARK-58509][ML][CONNECT] Exclude OneVsRest classifier from model size estimation #57715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhengruifeng wants to merge 1 commit into from
Closed

[SPARK-58509][ML][CONNECT] Exclude OneVsRest classifier from model size estimation #57715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,14 @@ final class OneVsRestModel private[ml] (
val numFeatures: Int = models.head.numFeatures

private[spark] override def estimatedSize: Long = {
estimateMatadataSize + SizeEstimator.estimate(labelMetadata) +
models.iterator.map(_.estimatedSize).sum
var size = estimateMatadataSize(excluded = Seq(
// classifier: Param[ClassifierType]
classifier))
// labelMetadata: Metadata
size += SizeEstimator.estimate(labelMetadata)
// models: Array[_ <: ClassificationModel[_, _]]
size += models.iterator.map(_.estimatedSize).sum
size
}

/** @group setParam */
Expand Down
9 changes: 6 additions & 3 deletions mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ class OneVsRestSuite extends MLTest with DefaultReadWriteTest {
ParamsSuite.checkParams(model)
}

test("SPARK-58250: OneVsRestModel estimated size") {
test("SPARK-58250 and SPARK-58509: OneVsRestModel estimated size") {
val trainingData = Seq(
(0.0, Vectors.dense(0.0, 0.0)),
(0.0, Vectors.dense(0.0, 1.0)),
Expand All @@ -77,13 +77,16 @@ class OneVsRestSuite extends MLTest with DefaultReadWriteTest {
(2.0, Vectors.dense(2.0, 0.0)),
(2.0, Vectors.dense(2.0, 1.0))).toDF("label", "features")

val classifier = new LogisticRegression().setMaxIter(1)
// Initialize the classifier's logger before retaining it in the OneVsRestModel.
classifier.fit(trainingData)
val model = new OneVsRest()
.setClassifier(new LogisticRegression().setMaxIter(1))
.setClassifier(classifier)
.fit(trainingData)

val maxSize = 32 * 1024
assert(model.estimatedSize < maxSize,
s"Estimation (${model.estimatedSize}) should be less than $maxSize")
s"Estimation (${model.estimatedSize}) should not include shared runtime state")
}

test("one-vs-rest: default params") {
Expand Down