[SPARK-58015][INFRA][FOLLOWUP] Make dependency group names compliant with the PyPA specification - #57729
Closed
ueshin wants to merge 1 commit into
Closed
[SPARK-58015][INFRA][FOLLOWUP] Make dependency group names compliant with the PyPA specification#57729ueshin wants to merge 1 commit into
ueshin wants to merge 1 commit into
Conversation
HyukjinKwon
approved these changes
Aug 3, 2026
uros-b
approved these changes
Aug 4, 2026
Member
|
LGTM, thank you @ueshin and @HyukjinKwon! |
Member
Author
|
Thanks! merging to master/4.x/4.3. |
ueshin
added a commit
that referenced
this pull request
Aug 4, 2026
…with the PyPA specification ### What changes were proposed in this pull request? This is a follow-up of #57093. This PR renames internal dependency groups in `pyproject.toml` from names beginning with `_` to names beginning with `internal_`. It also updates all corresponding `include-group` references. No package requirements or dependency group contents are changed. ### Why are the changes needed? The PyPA Dependency Groups specification requires group names to be valid non-normalized names. Such names must begin and end with an ASCII letter or number, so the existing names beginning with `_` are invalid. - https://packaging.python.org/en/latest/specifications/dependency-groups/#the-dependency-groups-table > [dependency-groups] keys, sometimes also called “group names”, must be [valid non-normalized names](https://packaging.python.org/en/latest/specifications/name-normalization/#name-format). Tools which handle Dependency Groups MUST [normalize](https://packaging.python.org/en/latest/specifications/name-normalization/#name-normalization) these names before comparisons. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The existing tests should pass. All dependency group names and `include-group` references were validated, including checks for missing references and duplicate normalized names. Also manually: ```sh $ uv pip install --dry-run --group pyproject.toml:dev ``` ### Was this patch authored or co-authored using generative AI tooling? Generated-by: OpenAI Codex (GPT-5) Closes #57729 from ueshin/dependency_group. Authored-by: Takuya UESHIN <ueshin@happy-camper.st> Signed-off-by: Takuya Ueshin <ueshin@happy-camper.st> (cherry picked from commit a38b122) Signed-off-by: Takuya Ueshin <ueshin@happy-camper.st>
ueshin
added a commit
that referenced
this pull request
Aug 4, 2026
…with the PyPA specification ### What changes were proposed in this pull request? This is a follow-up of #57093. This PR renames internal dependency groups in `pyproject.toml` from names beginning with `_` to names beginning with `internal_`. It also updates all corresponding `include-group` references. No package requirements or dependency group contents are changed. ### Why are the changes needed? The PyPA Dependency Groups specification requires group names to be valid non-normalized names. Such names must begin and end with an ASCII letter or number, so the existing names beginning with `_` are invalid. - https://packaging.python.org/en/latest/specifications/dependency-groups/#the-dependency-groups-table > [dependency-groups] keys, sometimes also called “group names”, must be [valid non-normalized names](https://packaging.python.org/en/latest/specifications/name-normalization/#name-format). Tools which handle Dependency Groups MUST [normalize](https://packaging.python.org/en/latest/specifications/name-normalization/#name-normalization) these names before comparisons. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The existing tests should pass. All dependency group names and `include-group` references were validated, including checks for missing references and duplicate normalized names. Also manually: ```sh $ uv pip install --dry-run --group pyproject.toml:dev ``` ### Was this patch authored or co-authored using generative AI tooling? Generated-by: OpenAI Codex (GPT-5) Closes #57729 from ueshin/dependency_group. Authored-by: Takuya UESHIN <ueshin@happy-camper.st> Signed-off-by: Takuya Ueshin <ueshin@happy-camper.st> (cherry picked from commit a38b122) Signed-off-by: Takuya Ueshin <ueshin@happy-camper.st>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of #57093.
This PR renames internal dependency groups in
pyproject.tomlfrom names beginning with_to names beginning withinternal_. It also updates all correspondinginclude-groupreferences.No package requirements or dependency group contents are changed.
Why are the changes needed?
The PyPA Dependency Groups specification requires group names to be valid non-normalized names. Such names must begin and end with an ASCII letter or number, so the existing names beginning with
_are invalid.Does this PR introduce any user-facing change?
No.
How was this patch tested?
The existing tests should pass. All dependency group names and
include-groupreferences were validated, including checks for missing references and duplicate normalized names.Also manually:
Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-5)