[SPARK-58553][PS] Use native Spark functions for NumPy fmax and fmin - #57758
Closed
zhengruifeng wants to merge 1 commit into
Closed
[SPARK-58553][PS] Use native Spark functions for NumPy fmax and fmin#57758zhengruifeng wants to merge 1 commit into
zhengruifeng wants to merge 1 commit into
Conversation
zhengruifeng
force-pushed
the
pandas-native-fmax-fmin-dev2
branch
from
August 4, 2026 12:21
c121116 to
2e280ae
Compare
uros-b
approved these changes
Aug 4, 2026
Member
|
LGTM |
zhengruifeng
added a commit
that referenced
this pull request
Aug 5, 2026
### What changes were proposed in this pull request? This PR replaces the pandas UDF implementations of `np.fmax` and `np.fmin` in pandas API on Spark with native Spark expressions. `fmax` explicitly selects the non-NaN operand before using `greatest`. `fmin` uses `least`, whose NaN ordering matches NumPy `fmin`. Both results are cast to `double`, matching the existing pandas UDF return type. ### Why are the changes needed? Using native Spark expressions avoids pandas UDF and Arrow overhead while preserving NumPy NaN-handling semantics. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added `NumPyCompatTests.test_np_fmax_fmin`, covering integral inputs, NaNs, infinities, and signed zero. - `ruff check python/pyspark/pandas/numpy_compat.py python/pyspark/pandas/tests/test_numpy_compat.py` - `ruff format --check python/pyspark/pandas/numpy_compat.py python/pyspark/pandas/tests/test_numpy_compat.py` - `python -m unittest pyspark.pandas.tests.test_numpy_compat.NumPyCompatTests.test_np_fmax_fmin` ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Codex GPT-5 Closes #57758 from zhengruifeng/pandas-native-fmax-fmin-dev2. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@foxmail.com> (cherry picked from commit 1762c91) Signed-off-by: Ruifeng Zheng <ruifengz@foxmail.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR replaces the pandas UDF implementations of
np.fmaxandnp.fminin pandas API on Spark with native Spark expressions.fmaxexplicitly selects the non-NaN operand before usinggreatest.fminusesleast, whose NaN ordering matches NumPyfmin. Both results are cast todouble, matching the existing pandas UDF return type.Why are the changes needed?
Using native Spark expressions avoids pandas UDF and Arrow overhead while preserving NumPy NaN-handling semantics.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added
NumPyCompatTests.test_np_fmax_fmin, covering integral inputs, NaNs, infinities, and signed zero.ruff check python/pyspark/pandas/numpy_compat.py python/pyspark/pandas/tests/test_numpy_compat.pyruff format --check python/pyspark/pandas/numpy_compat.py python/pyspark/pandas/tests/test_numpy_compat.pypython -m unittest pyspark.pandas.tests.test_numpy_compat.NumPyCompatTests.test_np_fmax_fminWas this patch authored or co-authored using generative AI tooling?
Generated-by: Codex GPT-5