[SPARK-58566][SQL][TESTS] Add tests for QuotingUtils.quoteIdentifier and escapeSingleQuotedString - #57766
Closed
uros-b wants to merge 1 commit into
Closed
[SPARK-58566][SQL][TESTS] Add tests for QuotingUtils.quoteIdentifier and escapeSingleQuotedString#57766uros-b wants to merge 1 commit into
uros-b wants to merge 1 commit into
Conversation
uros-b
changed the title
HyukjinKwon
approved these changes
Aug 4, 2026
zhengruifeng
approved these changes
Aug 5, 2026
szehon-ho
approved these changes
Aug 5, 2026
Member
Author
|
Thank you @HyukjinKwon @zhengruifeng @szehon-ho! |
uros-b
added a commit
that referenced
this pull request
Aug 5, 2026
…nd escapeSingleQuotedString ### What changes were proposed in this pull request? Adds unit tests for `QuotingUtils.quoteIdentifier` and `escapeSingleQuotedString`, which had no direct coverage. ### Why are the changes needed? These pure string helpers back-tick-escape identifiers and backslash-escape single quotes; the tests pin their contract (wrapping, doubling, escaping, empty input). ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? This PR is the test. `build/sbt "catalyst/testOnly *QuotingUtilsSuite"`. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8) Closes #57766 from uros-b/test-quotingutils. Authored-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com> Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com> (cherry picked from commit 6521926) Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com>
uros-b
added a commit
that referenced
this pull request
Aug 5, 2026
…nd escapeSingleQuotedString ### What changes were proposed in this pull request? Adds unit tests for `QuotingUtils.quoteIdentifier` and `escapeSingleQuotedString`, which had no direct coverage. ### Why are the changes needed? These pure string helpers back-tick-escape identifiers and backslash-escape single quotes; the tests pin their contract (wrapping, doubling, escaping, empty input). ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? This PR is the test. `build/sbt "catalyst/testOnly *QuotingUtilsSuite"`. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8) Closes #57766 from uros-b/test-quotingutils. Authored-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com> Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com> (cherry picked from commit 6521926) Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds unit tests for
QuotingUtils.quoteIdentifierandescapeSingleQuotedString, which had no direct coverage.Why are the changes needed?
These pure string helpers back-tick-escape identifiers and backslash-escape single quotes; the tests pin their contract (wrapping, doubling, escaping, empty input).
Does this PR introduce any user-facing change?
No.
How was this patch tested?
This PR is the test.
build/sbt "catalyst/testOnly *QuotingUtilsSuite".Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)