[SPARK-58589][SS] Drop redundant .apply on Function1 encoders in StateTypesEncoderUtils - #57792
Closed
uros-b wants to merge 1 commit into
Closed
[SPARK-58589][SS] Drop redundant .apply on Function1 encoders in StateTypesEncoderUtils#57792uros-b wants to merge 1 commit into
uros-b wants to merge 1 commit into
Conversation
uros-b
commented
Aug 5, 2026
uros-b
left a comment
uros-b
left a comment
Member
Author
There was a problem hiding this comment.
Waiting for CI and adding @HeartSaVioR for review
Contributor
|
Thanks! Merging to master/4.x. |
HeartSaVioR
pushed a commit
that referenced
this pull request
Aug 6, 2026
…eTypesEncoderUtils ### What changes were proposed in this pull request? Replaces the explicit `.apply(...)` calls with direct invocation on the encoder serializers, deserializers and unsafe projections in `StateTypesEncoderUtils` (19 call sites). ### Why are the changes needed? All of these receivers are `Function1` subtypes: `ExpressionEncoder.Serializer` extends `(T => InternalRow)`, `ExpressionEncoder.Deserializer` extends `(InternalRow => T)`, and `UnsafeProjection` extends `Projection`, which extends `(InternalRow => InternalRow)`. For a `Function1`, `f(x)` is exactly `f.apply(x)`, so the explicit form adds noise without meaning. The same file already calls several projections directly, so this removes an internal inconsistency rather than introducing a new style. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Syntactic change with identical semantics; existing transformWithState tests cover these paths. No new tests needed. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8) Closes #57792 from uros-b/style-statetypesencoder-apply. Authored-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com> Signed-off-by: Jungtaek Lim <kabhwan.opensource@gmail.com> (cherry picked from commit 41144ce) Signed-off-by: Jungtaek Lim <kabhwan.opensource@gmail.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replaces the explicit
.apply(...)calls with direct invocation on the encoder serializers, deserializers and unsafe projections inStateTypesEncoderUtils(19 call sites).Why are the changes needed?
All of these receivers are
Function1subtypes:ExpressionEncoder.Serializerextends(T => InternalRow),ExpressionEncoder.Deserializerextends(InternalRow => T), andUnsafeProjectionextendsProjection, which extends(InternalRow => InternalRow). For aFunction1,f(x)is exactlyf.apply(x), so the explicit form adds noise without meaning. The same file already calls several projections directly, so this removes an internal inconsistency rather than introducing a new style.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Syntactic change with identical semantics; existing transformWithState tests cover these paths. No new tests needed.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)