[SPARK-58615][ML] Avoid FPGrowthModel temporary column conflicts - #57816
Closed
zhengruifeng wants to merge 2 commits into
Closed
[SPARK-58615][ML] Avoid FPGrowthModel temporary column conflicts#57816zhengruifeng wants to merge 2 commits into
zhengruifeng wants to merge 2 commits into
Conversation
HyukjinKwon
approved these changes
Aug 6, 2026
zhengruifeng
added a commit
that referenced
this pull request
Aug 6, 2026
### What changes were proposed in this pull request? This follow-up to #57806 gives the transient association-rules column in `FPGrowthModel.transform` a generated name instead of the fixed name `rules`. It also adds regression coverage for an input dataset that already contains a `rules` column. ### Why are the changes needed? The fixed temporary column can conflict with an input column of the same name after the join, causing ambiguous-column analysis failures or dropping the user's column. ### Does this PR introduce _any_ user-facing change? Yes. `FPGrowthModel.transform` now supports and preserves an input column named `rules`. ### How was this patch tested? - `build/sbt -java-home /usr/lib/jvm/java-17-openjdk-amd64 mllib/Test/compile` - Added `FPGrowthSuite` coverage for an input `rules` column. The focused suite has not been run locally yet. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Codex (GPT-5) Closes #57816 from zhengruifeng/ml_fpgrowth_temp_rules_column. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@foxmail.com> (cherry picked from commit 5aeb251) Signed-off-by: Ruifeng Zheng <ruifengz@foxmail.com>
Contributor
Author
uros-b
reviewed
Aug 6, 2026
uros-b
left a comment
uros-b
left a comment
Member
There was a problem hiding this comment.
@zhengruifeng Should we also add a regression test that constructs an input dataset with a rules column and calls .transform? Can be in a followup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This follow-up to #57806 gives the transient association-rules column in
FPGrowthModel.transforma generated name instead of the fixed namerules. It also adds regression coverage for an input dataset that already contains arulescolumn.Why are the changes needed?
The fixed temporary column can conflict with an input column of the same name after the join, causing ambiguous-column analysis failures or dropping the user's column.
Does this PR introduce any user-facing change?
Yes.
FPGrowthModel.transformnow supports and preserves an input column namedrules.How was this patch tested?
build/sbt -java-home /usr/lib/jvm/java-17-openjdk-amd64 mllib/Test/compileFPGrowthSuitecoverage for an inputrulescolumn. The focused suite has not been run locally yet.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Codex (GPT-5)