Skip to content

[SPARK-58638][INFRA] Recognize Examples as a primary component tag in the merge script - #57848

Closed
uros-b wants to merge 1 commit into
apache:masterfrom
uros-b:SPARK-examples-primary
Closed

[SPARK-58638][INFRA] Recognize Examples as a primary component tag in the merge script#57848
uros-b wants to merge 1 commit into
apache:masterfrom
uros-b:SPARK-examples-primary

Conversation

@uros-b

@uros-b uros-b commented Aug 7, 2026

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This PR marks the EXAMPLES component as primary in the COMPONENTS registry of dev/merge_spark_pr.py, and makes the plural spelling the canonical tag.

EXAMPLE remains an accepted alias, so both [EXAMPLES] and [EXAMPLE] continue to be recognized; the canonical form used when the script rewrites a title is now the plural [EXAMPLES].

Why are the changes needed?

Since SPARK-56979, the merge script requires every PR title to carry at least one primary component tag. EXAMPLES maps to the JIRA component "Examples" and names a real top-level build module (examples/ in pom.xml), but it was not marked primary. As a result, a PR titled e.g. [SPARK-XXXXX][EXAMPLES] ... is rejected at merge time with:

PR title is missing a primary [COMPONENT] tag.
Primary components (one of these is required):
  ...
Enter comma-separated component(s) to insert into the title (e.g. CORE,SQL):

This forces the committer to bolt on a possibly unrelated primary tag, which produces worse changelog attribution than [EXAMPLES] alone for a change that lives entirely in the examples module. The plural [EXAMPLES] is also the more common historical spelling (92 vs 38 for the singular) and the form implied by deriving the tag from the JIRA component name ("Examples"), so it is made the canonical spelling while the singular stays as an alias.

Does this PR introduce any user-facing change?

No. This only affects the committer-facing interactive merge tool (dev/merge_spark_pr.py).

How was this patch tested?

  • Existing doctests pass:

    python3 -m doctest dev/merge_spark_pr.py
    
  • Manually verified against the registry and the merge-time gate.

Was this patch authored or co-authored using generative AI tooling?

Generated-by: Claude Code

@uros-b uros-b left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for CI; @cloud-fan please review.

@cloud-fan cloud-fan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 blocking, 0 non-blocking, 0 nits.
The registry change is consistent with the existing normalization and primary-component machinery, with no review findings.

Verification

Reviewed the changed registry entry and traced its canonicalization and primary-status consumption in the merge-time title normalization path. The author reports the existing doctests pass; tests were not rerun during this review.

@cloud-fan cloud-fan closed this in f572940 Aug 7, 2026
@cloud-fan

Copy link
Copy Markdown
Contributor

Merge Summary:

Posted by merge_spark_pr.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants