[SPARK-58638][INFRA] Recognize Examples as a primary component tag in the merge script - #57848
Closed
uros-b wants to merge 1 commit into
Closed
[SPARK-58638][INFRA] Recognize Examples as a primary component tag in the merge script#57848uros-b wants to merge 1 commit into
uros-b wants to merge 1 commit into
Conversation
uros-b
commented
Aug 7, 2026
uros-b
left a comment
Member
Author
There was a problem hiding this comment.
Waiting for CI; @cloud-fan please review.
cloud-fan
approved these changes
Aug 7, 2026
cloud-fan
left a comment
Contributor
There was a problem hiding this comment.
0 blocking, 0 non-blocking, 0 nits.
The registry change is consistent with the existing normalization and primary-component machinery, with no review findings.
Verification
Reviewed the changed registry entry and traced its canonicalization and primary-status consumption in the merge-time title normalization path. The author reports the existing doctests pass; tests were not rerun during this review.
Contributor
|
Merge Summary:
Posted by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR marks the
EXAMPLEScomponent asprimaryin theCOMPONENTSregistry ofdev/merge_spark_pr.py, and makes the plural spelling the canonical tag.EXAMPLEremains an accepted alias, so both[EXAMPLES]and[EXAMPLE]continue to be recognized; the canonical form used when the script rewrites a title is now the plural[EXAMPLES].Why are the changes needed?
Since SPARK-56979, the merge script requires every PR title to carry at least one primary component tag.
EXAMPLESmaps to the JIRA component "Examples" and names a real top-level build module (examples/inpom.xml), but it was not markedprimary. As a result, a PR titled e.g.[SPARK-XXXXX][EXAMPLES] ...is rejected at merge time with:This forces the committer to bolt on a possibly unrelated primary tag, which produces worse changelog attribution than
[EXAMPLES]alone for a change that lives entirely in the examples module. The plural[EXAMPLES]is also the more common historical spelling (92 vs 38 for the singular) and the form implied by deriving the tag from the JIRA component name ("Examples"), so it is made the canonical spelling while the singular stays as an alias.Does this PR introduce any user-facing change?
No. This only affects the committer-facing interactive merge tool (
dev/merge_spark_pr.py).How was this patch tested?
Existing doctests pass:
Manually verified against the registry and the merge-time gate.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code