Skip to content

[SPARK-58679][DOCS] Fix typos and grammar in the SQL name resolution reference doc - #57882

Open
uros-b wants to merge 1 commit into
apache:masterfrom
uros-b:typo-name-resolution-docs
Open

[SPARK-58679][DOCS] Fix typos and grammar in the SQL name resolution reference doc#57882
uros-b wants to merge 1 commit into
apache:masterfrom
uros-b:typo-name-resolution-docs

Conversation

@uros-b

@uros-b uros-b commented Aug 9, 2026

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Fixes nine spelling and grammar errors in docs/sql-ref-name-resolution.md:

  • precendece to precedence
  • Implict to Implicit
  • Successsful to Successful
  • raise a AMBIGUOUS_COLUMN_OR_FIELD to raise an ...
  • An fully qualified to A fully qualified
  • takes precedent to takes precedence
  • Columns and parameter win to Columns and parameters win
  • a column in table reference to a column in a table reference
  • removes a stray comma in takes precedence, over a lateral column alias

Why are the changes needed?

Most of these are proven wrong by the same file writing the phrase correctly elsewhere: it already has raise an AMBIGUOUS_COLUMN_OR_FIELD twice, a column name in a table reference, the adjacent A partially qualified and An unqualified, and takes precedence over seven times without a comma. takes precedent is the function-resolution example where a temporary function wins over a persistent one, so precedence is what was meant.

Does this PR introduce any user-facing change?

No, other than the corrected documentation.

How was this patch tested?

Documentation only. No error condition name, SQL keyword, identifier, or expected example output is touched: six of the fixes are on -- comment lines inside SQL example blocks, and AMBIGUOUS_COLUMN_OR_FIELD itself is unchanged (only the preceding article). Indentation of the nested list is byte-identical.

Was this patch authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Opus 4.8)

@uros-b uros-b left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for CI

@dongjoon-hyun dongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants