[SPARK-58822][SQL][TESTS] Extract a nonEmptyLines helper in LogicalPlanDifferenceSuite - #58048
Closed
uros-b wants to merge 1 commit into
Closed
[SPARK-58822][SQL][TESTS] Extract a nonEmptyLines helper in LogicalPlanDifferenceSuite#58048uros-b wants to merge 1 commit into
uros-b wants to merge 1 commit into
Conversation
uros-b
commented
Aug 17, 2026
Member
Author
|
Thank you @dongjoon-hyun! |
uros-b
added a commit
that referenced
this pull request
Aug 18, 2026
…nDifferenceSuite
### What changes were proposed in this pull request?
Extracts a single private helper in `LogicalPlanDifferenceSuite` and routes 20 call sites through it:
```scala
/** Splits `text` into lines, dropping any empty ones. */
private def nonEmptyLines(text: String): Array[String] =
text.split("\n").filter(_.nonEmpty)
```
### Why are the changes needed?
The idiom `X.split("\n").filter(_.nonEmpty)` was repeated 20 times, twice per test, which buries what each test is actually asserting under a parsing incantation. Naming it once reduces the per-test maintenance surface in this suite.
### Does this PR introduce _any_ user-facing change?
No. Test-only refactor.
### How was this patch tested?
Existing suite. The helper body is the extracted expression verbatim and keeps the `Array[String]` return type, so every downstream `.length`, index access, and `mkString` is unchanged; equivalence holds for empty, single-line, multi-line, and trailing-newline inputs. Scoped to this one file.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)
Closes #58048 from uros-b/helper-planvsplan-nonemptylines.
Authored-by: Uros <221401595+uros-b@users.noreply.github.com>
Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com>
(cherry picked from commit 67e7317)
Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com>
uros-b
added a commit
that referenced
this pull request
Aug 18, 2026
…nDifferenceSuite
### What changes were proposed in this pull request?
Extracts a single private helper in `LogicalPlanDifferenceSuite` and routes 20 call sites through it:
```scala
/** Splits `text` into lines, dropping any empty ones. */
private def nonEmptyLines(text: String): Array[String] =
text.split("\n").filter(_.nonEmpty)
```
### Why are the changes needed?
The idiom `X.split("\n").filter(_.nonEmpty)` was repeated 20 times, twice per test, which buries what each test is actually asserting under a parsing incantation. Naming it once reduces the per-test maintenance surface in this suite.
### Does this PR introduce _any_ user-facing change?
No. Test-only refactor.
### How was this patch tested?
Existing suite. The helper body is the extracted expression verbatim and keeps the `Array[String]` return type, so every downstream `.length`, index access, and `mkString` is unchanged; equivalence holds for empty, single-line, multi-line, and trailing-newline inputs. Scoped to this one file.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)
Closes #58048 from uros-b/helper-planvsplan-nonemptylines.
Authored-by: Uros <221401595+uros-b@users.noreply.github.com>
Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com>
(cherry picked from commit 67e7317)
Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Extracts a single private helper in
LogicalPlanDifferenceSuiteand routes 20 call sites through it:Why are the changes needed?
The idiom
X.split("\n").filter(_.nonEmpty)was repeated 20 times, twice per test, which buries what each test is actually asserting under a parsing incantation. Naming it once reduces the per-test maintenance surface in this suite.Does this PR introduce any user-facing change?
No. Test-only refactor.
How was this patch tested?
Existing suite. The helper body is the extracted expression verbatim and keeps the
Array[String]return type, so every downstream.length, index access, andmkStringis unchanged; equivalence holds for empty, single-line, multi-line, and trailing-newline inputs. Scoped to this one file.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)