[SPARK-9481][MLlib]Add logLikelihood to LocalLDAModel #7801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #39078 has finished for PR 7801 at commit
|
Member
There was a problem hiding this comment.
This is a lower bound, not an upper bound, on the log likelihood.
Member
|
This looks good, but it made me realize that gensim defines log perplexity as the negation of the log perplexity in the Online LDA paper's Eq 15. I prefer the Online LDA paper way, since low perplexity sounds like a good thing to me (whereas with gensim, high perplexity is better). I checked Stanford NLP, and they also say lower perplexity is better. Can you please modify the logPerplexity code to negate the returned value? |
added 2 commits
July 31, 2015 09:48
feynmanliang
force-pushed
the
SPARK-9481-logLikelihood
branch
from
f0996d8 to
6d1b2c9
Compare
|
Test build #39238 has finished for PR 7801 at commit
|
Member
|
LGTM, thanks! Merging with master |
feynmanliang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jkbradley Exposes
bound(variational log likelihood bound) through public API aslogLikelihood. Also adds unit tests, some DRYing ofLDASuite, and includes unit tests mentioned in #7760