-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-10689] [ML] [Doc] User guide and example code for AFTSurvivalRegression #9491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #45112 has finished for PR 9491 at commit
|
docs/ml-survival-regression.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the best way is to load some sample data into DataFrame like LiR and LoR, but I found it not very appropriate because:
If the data stored as text file, we need to define one case class like LabeledPoint which may confuse users;
If the data stored as Parquet/ORC file, users can not explore the data intuitively;
If the data stored as JSON, I think it's the best suitable way, but DataFrame can not load data with Vector type correctly.
|
@yanboliang We implemented a new approach for example code in user guide. Could you use |
|
Test build #45211 has finished for PR 9491 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too wide. Maybe we didn't turn on style check for code under examples/.
|
Test build #45352 has finished for PR 9491 at commit
|
|
LGTM. Merged into master and branch-1.6. Thanks! |
…ression Add user guide and example code for ```AFTSurvivalRegression```. Author: Yanbo Liang <ybliang8@gmail.com> Closes #9491 from yanboliang/spark-10689. (cherry picked from commit d50a66c) Signed-off-by: Xiangrui Meng <meng@databricks.com>
Add user guide and example code for
AFTSurvivalRegression.