Skip to content

Conversation

@yanboliang
Copy link
Contributor

Add user guide and example code for AFTSurvivalRegression.

@SparkQA
Copy link

SparkQA commented Nov 5, 2015

Test build #45112 has finished for PR 9491 at commit 5f4f6d8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the best way is to load some sample data into DataFrame like LiR and LoR, but I found it not very appropriate because:
If the data stored as text file, we need to define one case class like LabeledPoint which may confuse users;
If the data stored as Parquet/ORC file, users can not explore the data intuitively;
If the data stored as JSON, I think it's the best suitable way, but DataFrame can not load data with Vector type correctly.

@mengxr
Copy link
Contributor

mengxr commented Nov 5, 2015

@yanboliang We implemented a new approach for example code in user guide. Could you use include_example instead? This is an example: 820064e.

@SparkQA
Copy link

SparkQA commented Nov 6, 2015

Test build #45211 has finished for PR 9491 at commit ff9ddb9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaAFTSurvivalRegressionExample\n

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too wide. Maybe we didn't turn on style check for code under examples/.

@SparkQA
Copy link

SparkQA commented Nov 9, 2015

Test build #45352 has finished for PR 9491 at commit b36401d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaAFTSurvivalRegressionExample\n

@mengxr
Copy link
Contributor

mengxr commented Nov 9, 2015

LGTM. Merged into master and branch-1.6. Thanks!

@asfgit asfgit closed this in d50a66c Nov 9, 2015
asfgit pushed a commit that referenced this pull request Nov 9, 2015
…ression

Add user guide and example code for ```AFTSurvivalRegression```.

Author: Yanbo Liang <ybliang8@gmail.com>

Closes #9491 from yanboliang/spark-10689.

(cherry picked from commit d50a66c)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@yanboliang yanboliang deleted the spark-10689 branch November 10, 2015 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants