Skip to content

Conversation

@HeartSaVioR
Copy link
Contributor

@HeartSaVioR HeartSaVioR commented Apr 26, 2016

  • define MultiCount/LatencyStatAndMetric in let statement and set type hint to there

Before applying I got around 860,000 emitted/sec from BasicTopology, and after applying I got around 940,000~960,000 emitted/sec.
topology.disruptor.batch.size=10000

And it removes reflection warnings from lines which are recording stats.

Btw, though after applying this, invokeMatchingMethod is still on top 10. I'll track where it occurs.

* define MultiCount/LatencyStatAndMetric in let statement and set type hint to there
@unsleepy22
Copy link

+1
BTW. can we have more performance tests in more cases so that we can see the overall performance change?

@HeartSaVioR
Copy link
Contributor Author

HeartSaVioR commented Apr 26, 2016

@unsleepy22
Yeah, I really want to, but in order to do that we need a stable machines and benchmark tests.
(I'm doing performance tests on my laptop for now.)
We can give it a try with https://github.com/yahoo/streaming-benchmarks first.

@HeartSaVioR
Copy link
Contributor Author

And also ThroughputVsLatency topology in storm-starter.

@HeartSaVioR
Copy link
Contributor Author

@unsleepy22 Let's move to #1362. I'll address the performance tests there.

@HeartSaVioR
Copy link
Contributor Author

Please refer #816. I'm confused completely why this happens cause those lines are introduced at 16c33ef which fixes the reflection issue. Why it is broken again?

@HeartSaVioR HeartSaVioR changed the title STORM-1729 Get rid of reflections while recording stats STORM-1729 (1.x) Get rid of reflections while recording stats Apr 27, 2016
@asfgit asfgit merged commit ae78815 into apache:1.x-branch Apr 27, 2016
@ptgoetz
Copy link
Member

ptgoetz commented Apr 27, 2016

+1 (forgot to do so before merging)

@HeartSaVioR HeartSaVioR deleted the STORM-1729-1.x-branch branch June 30, 2017 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants