STORM-3188: Remove try-catch block from getAndResetWorkerHeartbeats#3140
Closed
daisyxchen wants to merge 1 commit into
Closed
STORM-3188: Remove try-catch block from getAndResetWorkerHeartbeats#3140daisyxchen wants to merge 1 commit into
daisyxchen wants to merge 1 commit into
Conversation
| return null; | ||
| } | ||
| localHeartbeats = SupervisorUtils.readWorkerHeartbeats(this.conf); | ||
| return getSupervisorWorkerHeartbeatsFromLocal(localHeartbeats); |
Contributor
There was a problem hiding this comment.
The method is called in from run method https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/daemon/supervisor/timer/ReportWorkerHeartbeats.java#L45-L49
This try catch loop ensures that thread does not die.
Not sure what this PR is trying to accomplish. Please elaborate.
Contributor
Author
There was a problem hiding this comment.
According to the request in ticket https://issues.apache.org/jira/browse/STORM-3188, is the try catch necessary?
Contributor
There was a problem hiding this comment.
I think it is. Maybe we should close the issue as won't fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.