Skip to content

STORM-3188: Remove try-catch block from getAndResetWorkerHeartbeats #3140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daisyxchen wants to merge 1 commit into from
Closed

STORM-3188: Remove try-catch block from getAndResetWorkerHeartbeats #3140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions ...server/src/main/java/org/apache/storm/daemon/supervisor/timer/ReportWorkerHeartbeats.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,8 @@ public void run() {

private SupervisorWorkerHeartbeats getAndResetWorkerHeartbeats() {
Map<String, LSWorkerHeartbeat> localHeartbeats;
try {
localHeartbeats = SupervisorUtils.readWorkerHeartbeats(this.conf);
return getSupervisorWorkerHeartbeatsFromLocal(localHeartbeats);
} catch (Exception e) {
LOG.error("Read local worker heartbeats error, skipping heartbeats for this round, msg:{}", e.getMessage());
return null;
}
localHeartbeats = SupervisorUtils.readWorkerHeartbeats(this.conf);
return getSupervisorWorkerHeartbeatsFromLocal(localHeartbeats);
Copy link
Copy Markdown
Contributor

@kishorvpatil kishorvpatil Oct 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method is called in from run method https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/daemon/supervisor/timer/ReportWorkerHeartbeats.java#L45-L49
This try catch loop ensures that thread does not die.
Not sure what this PR is trying to accomplish. Please elaborate.

Copy link
Copy Markdown
Contributor Author

@daisyxchen daisyxchen Oct 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the request in ticket https://issues.apache.org/jira/browse/STORM-3188, is the try catch necessary?

Copy link
Copy Markdown
Contributor

@srdo srdo Oct 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is. Maybe we should close the issue as won't fix.

}

private SupervisorWorkerHeartbeats getSupervisorWorkerHeartbeatsFromLocal(Map<String, LSWorkerHeartbeat> localHeartbeats) {
Expand Down