build: run ASF allowlist check on every PR so the required check reports#8887
Merged
Conversation
The workflow had a paths filter (.github/**) on the pull_request trigger, so it only ran when a PR touched .github/**. Since asf-allowlist-check is a required status check in .asf.yaml, every other PR stayed in the 'Expected — waiting for status' state and could never be merged. Drop the paths filter on pull_request (mirroring apache/opennlp) so the check runs and reports a status on all PRs. The push trigger keeps its paths filter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
asf-allowlist-checkworkflow had apaths: [".github/**"]filter on itspull_requesttrigger, so it only ran when a PR touched.github/**.Since
asf-allowlist-checkis configured as a required status check in.asf.yaml, every PR that does not touch.github/**stayed in theExpected — waiting for statusstate and could never be merged (mergeStateStatus: BLOCKED), even with all other builds green.This drops the
pathsfilter on thepull_requesttrigger (mirroring the working setup in apache/opennlp) so the check runs and reports a status on every PR. Thepushtrigger keeps itspathsfilter since branch pushes only need re-validation when workflows change.No functional change to what the check validates.