Decode netty server frames only after the handshake completes - #8993
Merged
Conversation
GGraziadei
force-pushed
the
gate-preauth-frame-decoding
branch
from
August 22, 2026 11:58
46d316d to
74b872f
Compare
rzo1
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
storm.messaging.netty.authenticationenabled, the decoder handles only handshake frames until the handshake completes; other frames close the connection instead of being buffered or deserialized.Testing
mvn -pl storm-client test -DskipITs(631 tests, 0 failures)MessageDecoderTestcovers both pipeline modes, before and after the handshake.