Conversation
|
@GuiForget any thoughts on this? |
There was a problem hiding this comment.
I would check for null and make a copy of the map
There was a problem hiding this comment.
Ok given that for now you use the Metadata class just as a wrapper, making a copy isn't possible. Checking for null is probably a good idea still
There was a problem hiding this comment.
this is temporary indeed. Am now throwing an exception when the value is null.
|
thanks for your comments Gui |
|
Quite a large change, I think we should release 0.4 first then merge this. |
|
Now that we've released 0.4, should we make this priority 1? I think several other issues are affected by the new metadata scheme |
|
Yes yes yes!!! 💃 My only concern is should we just go further and replace the use of Map<String, String[]> with Metadata class right away? |
|
+1 to make it top priority. I will take care of this.
that's what the old PR was attempting to do, might as well do it all in one go. Can't output it from a bolt and not get the following bolt to handle them, can't we? |
|
Opened a new PR #78 |
Having a wrapper for Metadata would be a bit more elegant than moving the Map<String,String[]> around.
This initial implementation adds Metadata and removes the KeyValues utility. Later on we can replace all occurrences of Map<String,String[]> and systematically use Metadata instead.