Conversation
…nd protocol The bolts still emit Map<String,String[]> to the subsequent bolts for now.
…nd protocol The bolts still emit Map<String,String[]> to the subsequent bolts for now.
I replaced the old Map<String,String[]> with Metadata in all the interfaces (urlfilters, parsefilters) as well as the bolts
|
Note to self : read about serialization in Storm and Kryo |
Can now use Metadata with Storm in distributed mode
|
@DigitalPebble/committers-crawler could you please review this? |
There was a problem hiding this comment.
There's also a non static registerSerialization on the Config object
There was a problem hiding this comment.
any reason to use one and not the other?
There was a problem hiding this comment.
None. Except my preference for non-static method :)
|
Looks good to me. I noticed your code formatter adds a space after the |
|
Thanks for reviewing this Gui. Haven't found how to change the code formatter to do that. Will start working on the merge and commit once I've heard back from you on the points above. |
|
Looks good |
Replace Map<String,String[]> with serializable Metadata in Fetcher and protocol
2 participants
The bolts still emit Map<String,String[]> to the subsequent bolts for now.
Replaces #36
Still need to port to other parts of the code but we can already discuss possible improvements to it now.