feat: auto-refresh Diagram tab on struts.xml DOM changes - #101
Merged
Conversation
Extract isDomElementInFile for unit testing before wiring the listener. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Register a debounced DomEventListener while the Diagram tab is active and rebuild immediately on tab selection. Closes #97. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Document the brainstorming output and task plan for issue #97. Co-authored-by: Cursor <cursoragent@cursor.com>
lukaszlenart
enabled auto-merge (squash)
June 25, 2026 18:37
Contributor
|
🔌 Plugin artifact ready for testing! Download from Actions artifacts Artifact: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DomEventListenerinStruts2DiagramFileEditorthat rebuilds the diagram when the samestruts.xmlfile changes while the Diagram tab is activeselectNotify) so edits made on the Text tab are reflected without reopening the fileCloses #97
Test plan
./gradlew test -x rat— full suite passesStruts2DiagramFileEditorDomFilterTest— same-file / cross-file / null filteringStruts2DiagramFileEditorProviderTest— lifecycle (selectNotify/deselectNotify,reset)./gradlew runIde— edit on Text tab, switch to Diagram; edit while on Diagram tab (300 ms debounce)Made with Cursor