adds analytics logging on db create and test connections #13344
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
* fix: button margin glitches * removing unncessary fragment * removing grid gap * Revert "removing unncessary fragment" This reverts commit 659e273.
* refactor(api): csrf token on the new REST API * improve OpenAPI spec description * fix test * remove public role like has default for all tests * fix test
…#13235) raise_for_dashboard_access is part of dashboard and cannot be overridden by a security manager.
…he#12238) * Update index.mdx Pinot connection fix * Update index.mdx
* feat: add trino logo Signed-off-by: Đặng Minh Dũng <dungdm93@live.com> * chores: update image links in README.md Signed-off-by: Đặng Minh Dũng <dungdm93@live.com> * docs: add Trino Connecting to Databases doc Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>
* update preset file * migration added * bug fix * lint * Update superset/migrations/versions/1412ec1e5a7b_legacy_force_directed_to_echart.py Co-authored-by: Jesse Yang <jesse.yang@airbnb.com> * version bump * bummp dependency * add package.lock * merge migrations * add integration test * lint * remove unnecessary params from test * check key existance in migrations * test to typescript * Update graph.test.ts * fix migration downstream head * Upgrade to lockfileversion 2 Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
…ache#13271) * feat(chart-data): add rowcount, timegrain and column result types * break out actions from query_context * rename module
* fix: project None value * fix: pre-commit
* First pass at ephemeral env, new Docker ci target * Add service checks, get public IP * Separate issue_comment and workflow_run jobs * Refactor workflows * Adjust comment author association * Checkout code * Fix image name, manage service desired task count * Use merge commit sha * Fix IP output, add failure comment * Refactor comment parsing & env spinup * Check container image publish status * Parse AWS account ID from registry URL * Use PR number rather than variable merge commit SHA for image tag * Fix docker push conditional * Push multiple tags to ECR * Fix comment author check * Refactor comment body check * Provision service with active task to get correct IP * /testenv up * Add @mentions to PR comments, env var cleanup
* fix: add config to disable dataset ownership on the old api * fix CI docker build * fix logic * add deprecation comment on the config * feat: send alerts reports errors to recipients * update * feat(reports): send notification on error with grace * merge and revert config * fix lint and MySQL test * fix mysql tests
eschutho
commented
Feb 25, 2021
| with closing(engine.raw_connection()) as conn: | ||
| if not engine.dialect.do_ping(conn): | ||
| raise DBAPIError(None, None, None) | ||
| with closing(engine.raw_connection()) as conn: |
Member
Author
There was a problem hiding this comment.
I'm not sure what the intention was here, but if database is None, then this statement fails because engine is not defined, so I put it inside this block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
adds analytics logging on db create and test connections
TEST PLAN
unit tests added
ADDITIONAL INFORMATION