Skip to content

Conversation

@betodealmeida
Copy link
Member

SUMMARY

Use numeric separators to increase readability.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

N/A

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #15267 (5f07272) into master (a102715) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 5f07272 differs from pull request most recent head 13c70a3. Consider uploading reports for the commit 13c70a3 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15267   +/-   ##
=======================================
  Coverage   77.26%   77.26%           
=======================================
  Files         972      972           
  Lines       50315    50315           
  Branches     6140     6140           
=======================================
  Hits        38876    38876           
  Misses      11235    11235           
  Partials      204      204           
Flag Coverage Δ
javascript 71.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/SqlLab/components/QueryAutoRefresh.jsx 65.90% <100.00%> (ø)
...erset-frontend/src/SqlLab/components/SqlEditor.jsx 55.04% <100.00%> (ø)
...rset-frontend/src/components/LastUpdated/index.tsx 96.00% <100.00%> (ø)
superset-frontend/src/explore/controls.jsx 28.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a102715...13c70a3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant