Skip to content

chore: use numeric separators on big numbers #15267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
betodealmeida wants to merge 1 commit into from
Closed

chore: use numeric separators on big numbers #15267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions superset-frontend/src/SqlLab/components/QueryAutoRefresh.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ import * as Actions from '../actions/sqlLab';

const QUERY_UPDATE_FREQ = 2000;
const QUERY_UPDATE_BUFFER_MS = 5000;
const MAX_QUERY_AGE_TO_POLL = 21600000;
const QUERY_TIMEOUT_LIMIT = 10000;
const MAX_QUERY_AGE_TO_POLL = 21_600_000;
const QUERY_TIMEOUT_LIMIT = 10_000;

class QueryAutoRefresh extends React.PureComponent {
constructor(props) {
Expand Down
2 changes: 1 addition & 1 deletion superset-frontend/src/SqlLab/components/SqlEditor.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ import SqlEditorLeftBar from './SqlEditorLeftBar';
import AceEditorWrapper from './AceEditorWrapper';
import RunQueryActionButton from './RunQueryActionButton';

const LIMIT_DROPDOWN = [10, 100, 1000, 10000, 100000];
const LIMIT_DROPDOWN = [10, 100, 1000, 10_000, 100_000];
const SQL_EDITOR_PADDING = 10;
const INITIAL_NORTH_PERCENT = 30;
const INITIAL_SOUTH_PERCENT = 70;
Expand Down
2 changes: 1 addition & 1 deletion superset-frontend/src/components/LastUpdated/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import moment, { Moment, MomentInput } from 'moment';
import { t, styled } from '@superset-ui/core';
import Icon from 'src/components/Icon';

const REFRESH_INTERVAL = 60000; // every minute
const REFRESH_INTERVAL = 60_000; // every minute

interface LastUpdatedProps {
updatedAt: MomentInput;
Expand Down
4 changes: 2 additions & 2 deletions superset-frontend/src/explore/controls.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export const D3_FORMAT_OPTIONS = [
['DURATION_SUB', 'Duration in ms (100.40008 => 100ms 400µs 80ns)'],
];

const ROW_LIMIT_OPTIONS = [10, 50, 100, 250, 500, 1000, 5000, 10000, 50000];
const ROW_LIMIT_OPTIONS = [10, 50, 100, 250, 500, 1000, 5000, 10_000, 50_000];

const SERIES_LIMITS = [0, 5, 10, 25, 50, 100, 500];

Expand Down Expand Up @@ -361,7 +361,7 @@ export const controls = {
freeForm: true,
label: t('Row limit'),
validators: [legacyValidateInteger],
default: 10000,
default: 10_000,
choices: formatSelectOptions(ROW_LIMIT_OPTIONS),
},

Expand Down