chore: merge into refactorReports by AAfghahi · Pull Request #19998 · apache/superset

AAfghahi · 2022-05-09T16:18:14Z

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

…pache#19854) * fix api for checking owners * fix styles for disabling * fix styles for disabling * fix lint * fix lint * add owners key * plzz * remove * update test * add tooltip * add type * fix test * fix user reference * lit * fix test * work

…pache#19894) Bumps [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) from 3.3.1 to 4.0.0. - [Release notes](https://github.com/prettier/eslint-plugin-prettier/releases) - [Changelog](https://github.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md) - [Commits](prettier/eslint-plugin-prettier@v3.3.1...v4.0.0) --- updated-dependencies: - dependency-name: eslint-plugin-prettier dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

) Bumps [cross-fetch](https://github.com/lquixada/cross-fetch) from 3.1.4 to 3.1.5. - [Release notes](https://github.com/lquixada/cross-fetch/releases) - [Commits](lquixada/cross-fetch@v3.1.4...v3.1.5) --- updated-dependencies: - dependency-name: cross-fetch dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: deprecate old API on core superset fave_dashboards * fix js lint * remove unused type

apache#18988) * fix(column-header-tooltip): make that hide the tooltip when the cloumn header is turncated * fix(column-header-tooltip): fix lint * fix(column-header-tooltip): make to dynamic tooltip header in FilterTable * fix(column-header-tooltip): make to fix the lint issue * fix(column-header-tooltip): make to remove the tooltip option * fix(column-header-tooltip): make to add test and storybook for dynamic tooltip * fix(column-header-tooltip): make to fix lint

…pache#19826)

…pache#19916) Bumps [react-virtualized-auto-sizer](https://github.com/bvaughn/react-virtualized-auto-sizer) from 1.0.2 to 1.0.6. - [Release notes](https://github.com/bvaughn/react-virtualized-auto-sizer/releases) - [Commits](https://github.com/bvaughn/react-virtualized-auto-sizer/commits) --- updated-dependencies: - dependency-name: react-virtualized-auto-sizer dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…in the history tab on sync mode (apache#19362)" (apache#19906) This reverts commit 6d5d03e.

…9927)

* feat: get user roles endpoint * add tests * fix test * get user with permission and roles with full user * frontend * type juggling * the hash slinging slasher * user reducer and action * make it happy * result * lint Co-authored-by: Lily Kuang <lily@preset.io>

* fix: can not correctly set force in store * fix ut

… result in out of bounds timestamp (apache#18873) * fix casting from timestamp[us] to timestamp[ns] would result in out of bounds timestamp from sqllab and charts * Add unittests * Lint changes and parameter variable rename * Fix linting

…che#19921) * feat: deprecate /superset/extra_table_metadata migrate to api v1 * use can_read to table_extra_metadata * troubleshoot sqlite * fix test * fix test * fix test * fix frontend test on sqllab

* fix(hive): Workaround for Python 3.9 s3 transfer issue * Update hive.py

…ouse target is larger (apache#19839)

* remove druid datasource from the config * remove config related references to DruidDatasource * Update __init__.py * Update __init__.py * Update manager.py * remove config related references to DruidDatasource * raise if instance type is not valid

…apache#19938) * fix(chart & table): make to allow highlight in case of numeric column * fix(chart & table): make to use emitFilter directly * fix(chart & table): make to use styled component instead of inline style

…#19957)

…ing (apache#19942)

* Test storybook workflow * Add test workflow * Fix eof * Update workflow * Install apt dependencies * Schedule nightly * Enhance workflow * Add secret Applitools key * Update config * Add batchName

* WIP * Attempt Github Actions integration * Add completion notification to workflow * Update env * Add new line * Add license * Fix whitespaces * Fix Yaml indentation * Fix afterEach * Add initial tests * Update config * Use test secret * Clean up * Add batchName * Disable logs - add secret * Create separate workflow * Clean up * Update workflow * Exclude applitools tests * Update jobs name * Run applitools tests separetely * Fix path pattern * Run once * Add more initial tests * Enhance tests * Add dashboard edit mode test * Move env * Exclude applitools from sqllab test run * Attempt pull_request_target * Catch Applitools failures * Clean up tests * Add test step * Add test step * Remove step * Fix SqlLab test * Update CURL request * Fix Yaml * Add empty data to batch completion

…he#19923) * chore: Removes hard-coded colors from the plugins - iteration 1 * Fixes lint errors * Fixes tests

* fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (apache#16358) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor(reports): Arash/refactor reports (apache#16855) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> * code dry (apache#16358) * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor: Reports - ReportModal (apache#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * report pickup Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> * refactor(reports): Arash/again refactor reports (apache#16872) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> * code dry (apache#16358) * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor: Reports - ReportModal (apache#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * it is still not working Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> * next changes Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* Add delete functionality * Report schema restructure progress * Fix lint * Removed console.log

* Remove on close * Fix lint * Add tests

) * Added sunburst echart * fix(dashboard):Hide reports modal for anonymous users * Address comments * Make prettier happy Co-authored-by: Mayur <mayurp@kpmg.com>

…taset (apache#17503)

* pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> * code dry (apache#16358) * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> * code dry (apache#16358) * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor: Arash/new state report (apache#16987) * code dry (apache#16358) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor(reports): Arash/refactor reports (apache#16855) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> * code dry (apache#16358) * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor: Reports - ReportModal (apache#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * report pickup Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> * refactor(reports): Arash/again refactor reports (apache#16872) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> * code dry (apache#16358) * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor: Reports - ReportModal (apache#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * it is still not working Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> * next changes Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> * refactor: Reports code clean 10-29 (apache#17424) * Add delete functionality * Report schema restructure progress * Fix lint * Removed console.log * fix(Explore): Remove changes to the properties on cancel (apache#17184) * Remove on close * Fix lint * Add tests * fix(dashboard): don't show report modal for anonymous user (apache#17106) * Added sunburst echart * fix(dashboard):Hide reports modal for anonymous users * Address comments * Make prettier happy Co-authored-by: Mayur <mayurp@kpmg.com> * fix(explore): Metric control breaks when saved metric deleted from dataset (apache#17503) * Add functionality is now working (apache#17578) * refactoring reports * ready for review * added testing * removed user reducer * elizabeth suggestions Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> Co-authored-by: Geido <60598000+geido@users.noreply.github.com> Co-authored-by: Mayur <mayurnewase111@gmail.com> Co-authored-by: Mayur <mayurp@kpmg.com> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>

AAfghahi and others added 30 commits April 29, 2022 17:06

added gtag (apache#19602)

ada1575

feat: simplify memoized_func (apache#19905)

aff10a7

feat: deprecate old API on core superset fave_dashboards (apache#19754)

85b0ef8

* feat: deprecate old API on core superset fave_dashboards * fix js lint * remove unused type

Fix issue probably-meant-fstring found at https://codereview.doctor (a…

50dc7af

…pache#19826)

Revert "fix(sql lab): display the 'View Results' button consistently …

1fa841e

…in the history tab on sync mode (apache#19362)" (apache#19906) This reverts commit 6d5d03e.

fix (dataset): DAO update (apache#19926)

8b6e582

feat(chart & legend): make to enable show legend by default (apache#1…

7b3d0f0

…9927)

fix: memoize primitives (apache#19930)

1ebdaac

fix(sqla): replace custom dttm type with literal_column (apache#19917)

99f1f9e

feat: simplify SQLite time grain (apache#19745)

90130e4

Improving logging around failed scheduled reports (apache#19924)

e1f53f2

chore: Adds a storybook to FilterableTable (apache#19897)

7657e42

fix: can not correctly set force in store (apache#19932)

24e4ab6

* fix: can not correctly set force in store * fix ut

fix: OpenAPI docs small fixes (apache#19936)

5dd3ea1

chore: Adds theme object to chart properties (apache#19951)

e9032e9

feat: deprecate /superset/extra_table_metadata migrate to api v1 (apa…

4fdf230

…che#19921) * feat: deprecate /superset/extra_table_metadata migrate to api v1 * use can_read to table_extra_metadata * troubleshoot sqlite * fix test * fix test * fix test * fix frontend test on sqllab

fix(hive): Workaround for Python 3.9 s3 transfer issue (apache#19887)

fdf48c6

* fix(hive): Workaround for Python 3.9 s3 transfer issue * Update hive.py

Fix broken link for DouroECI (apache#19911)

06b7dea

Modified the markdown component so that the inner column's handle's m…

7d3437a

…ouse target is larger (apache#19839)

feat: switch from sqlalchemy-trino to trino python client (apache…

58e65ad

…#19957)

refactor(ReportModal): simplify state reducer and improve error handl…

7b88ec7

…ing (apache#19942)

geido and others added 26 commits May 9, 2022 14:17

feat: Run Applitools on public Storybook (apache#19852)

c3ba86e

* Test storybook workflow * Add test workflow * Fix eof * Update workflow * Install apt dependencies * Schedule nightly * Enhance workflow * Add secret Applitools key * Update config * Add batchName

chore: Removes hard-coded colors from the plugins - iteration 1 (apac…

b7cff83

…he#19923) * chore: Removes hard-coded colors from the plugins - iteration 1 * Fixes lint errors * Fixes tests

bumping shillelagh

05251eb

pexdax refactor (apache#16333)

85f0777

refactor progress (apache#16339)

847fbe5

fix: Header Actions test refactor (apache#16336)

5b0adc4

* fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

code dry (apache#16358)

3e15c54

Fetch bug fixed (apache#16376)

f2be4bc

continued refactoring (apache#16377)

473c603

pexdax refactor (apache#16333)

616a35d

refactor progress (apache#16339)

2a4b38d

fix: Header Actions test refactor (apache#16336)

49ec8e5

* fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

code dry (apache#16358)

0a89c1b

Fetch bug fixed (apache#16376)

2eb5c8f

continued refactoring (apache#16377)

e8ec94d

refactor: Reports code clean 10-29 (apache#17424)

a355dfc

* Add delete functionality * Report schema restructure progress * Fix lint * Removed console.log

fix(Explore): Remove changes to the properties on cancel (apache#17184)

5844998

* Remove on close * Fix lint * Add tests

fix(dashboard): don't show report modal for anonymous user (apache#17106

db6821a

) * Added sunburst echart * fix(dashboard):Hide reports modal for anonymous users * Address comments * Make prettier happy Co-authored-by: Mayur <mayurp@kpmg.com>

fix(explore): Metric control breaks when saved metric deleted from da…

0476b80

…taset (apache#17503)

Add functionality is now working (apache#17578)

6b457e9

deleted additional folder

6f45dc7

fixing tests

0a5d8eb

all but styling

e0dae4a

pull-request-size bot added the size/XXL label May 9, 2022

AAfghahi changed the title ~~Refactor reprots~~ chore: merge into refactorReports May 9, 2022

AAfghahi merged commit b69390e into apache:refactorReports May 9, 2022

AAfghahi deleted the refactorReprots branch May 9, 2022 16:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: merge into refactorReports#19998

chore: merge into refactorReports#19998
AAfghahi merged 62 commits intoapache:refactorReportsfrom
preset-io:refactorReprots

AAfghahi commented May 9, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Comments

Conversation

AAfghahi commented May 9, 2022

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Comments