Skip to content

fix(docs): Use modern driver package for CrateDB#38358

Open
amotl wants to merge 2 commits intoapache:masterfrom
crate-workbench:cratedb-docs
Open

fix(docs): Use modern driver package for CrateDB#38358
amotl wants to merge 2 commits intoapache:masterfrom
crate-workbench:cratedb-docs

Conversation

@amotl
Copy link
Contributor

@amotl amotl commented Mar 3, 2026

Dear Superset maintainers,

on the documentation page about CrateDB, we discovered a possible leftover from the migration from crate[sqlalchemy] to sqlalchemy-cratedb the other day.

Other than merging to master, can you possibly commandeer this patch to be backported to earlier releases of Superset? Thank you in advance!

With kind regards,
Andreas.

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Mar 3, 2026

Code Review Agent Run #e4987e

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: e4dd969..5d7abd0
    • superset/db_engine_specs/crate.py
  • Files skipped - 1
    • docs/src/data/databases.json - Reason: Filter setting
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Mar 3, 2026
@dosubot dosubot bot added the data:connect Namespace | Anything related to db connections / integrations label Mar 3, 2026
@netlify
Copy link

netlify bot commented Mar 3, 2026

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 5d7abd0
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/69a69c94902de80009c4bbd0
😎 Deploy Preview https://deploy-preview-38358--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.98%. Comparing base (1bd0546) to head (5d7abd0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #38358      +/-   ##
==========================================
+ Coverage   64.29%   64.98%   +0.68%     
==========================================
  Files        1811     2484     +673     
  Lines       71491   123339   +51848     
  Branches    22775    28648    +5873     
==========================================
+ Hits        45965    80151   +34186     
- Misses      25526    41791   +16265     
- Partials        0     1397    +1397     
Flag Coverage Δ
hive 41.11% <ø> (?)
mysql 64.05% <ø> (?)
postgres 64.13% <ø> (?)
presto 41.13% <ø> (?)
python 65.90% <ø> (?)
sqlite 63.72% <ø> (?)
unit 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:connect Namespace | Anything related to db connections / integrations doc Namespace | Anything related to documentation size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant