fix(dev): fix simple-zstd v2 API breakage in webpack proxy config by michael-s-molina · Pull Request #39138 · apache/superset

michael-s-molina · 2026-04-06T13:43:12Z

SUMMARY

#38662 bumped simple-zstd from 1.4.2 to 2.1.0. That version is a breaking release that renamed ZSTDDecompress to decompress and made it async (returns a Promise<stream> instead of a stream directly).

This caused the webpack dev proxy to crash when the backend responds with content-encoding: zstd:

TypeError: ZSTDDecompress is not a function
Then TypeError: dest.on is not a function (when trying to pipe into a Promise)

Fix:

Update import from ZSTDDecompress to decompress
Make processHTML async and await the decompress() call so a proper stream is returned before piping

Caused by: #38662

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Start the Superset backend
Run npm run dev in superset-frontend/
Navigate to http://localhost:9000/login/ — should load without proxy errors in the console

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

bito-code-review · 2026-04-06T13:43:23Z

Code Review Agent Run #754863

Actionable Suggestions - 0

Review Details

Files reviewed - 1 · Commit Range: 18a5c02..18a5c02
- superset-frontend/webpack.proxy-config.js
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

simple-zstd v2 renamed ZSTDDecompress to decompress and made it async. Update the import and await the call in processHTML to get a proper stream. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

codecov · 2026-04-06T14:08:28Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.52%. Comparing base (d796543) to head (d76ed19).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #39138   +/-   ##
=======================================
  Coverage   64.52%   64.52%           
=======================================
  Files        2536     2536           
  Lines      131208   131208           
  Branches    30457    30457           
=======================================
  Hits        84661    84661           
  Misses      45084    45084           
  Partials     1463     1463

Flag	Coverage Δ
javascript	`66.06% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…t-frontend Reverts apache#38662. The v2 bump introduced breaking API changes that caused npm run dev-server to stop working. Even with the fixes in apache#39138 the application was still freezing. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

michael-s-molina · 2026-04-06T14:09:42Z

Closing in favor of #39139

bito-code-review · 2026-04-06T14:53:08Z

Code Review Agent Run #2ee983

Actionable Suggestions - 0

Review Details

Files reviewed - 1 · Commit Range: d76ed19..d76ed19
- superset-frontend/webpack.proxy-config.js
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

pull-request-size Bot added the size/XS label Apr 6, 2026

dosubot Bot added the dependencies:npm label Apr 6, 2026

michael-s-molina requested review from hainenber, msyavuz and rusackas April 6, 2026 13:43

hainenber approved these changes Apr 6, 2026

View reviewed changes

fix(dev): update simple-zstd API usage in webpack proxy config

d76ed19

simple-zstd v2 renamed ZSTDDecompress to decompress and made it async. Update the import and await the call in processHTML to get a proper stream. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

michael-s-molina force-pushed the fix/zstd-decompress-proxy branch from 18a5c02 to d76ed19 Compare April 6, 2026 13:49

pull-request-size Bot added size/S and removed size/XS labels Apr 6, 2026

github-actions Bot removed the dependencies:npm label Apr 6, 2026

michael-s-molina mentioned this pull request Apr 6, 2026

fix(deps): revert simple-zstd from 2.1.0 back to 1.4.2 #39139

Merged

9 tasks

michael-s-molina closed this Apr 6, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(dev): fix simple-zstd v2 API breakage in webpack proxy config#39138

fix(dev): fix simple-zstd v2 API breakage in webpack proxy config#39138
michael-s-molina wants to merge 1 commit intoapache:masterfrom
michael-s-molina:fix/zstd-decompress-proxy

michael-s-molina commented Apr 6, 2026

Uh oh!

bito-code-review Bot commented Apr 6, 2026 •

edited

Loading

Code Review Agent Run #754863

Uh oh!

codecov Bot commented Apr 6, 2026 •

edited

Loading

Uh oh!

michael-s-molina commented Apr 6, 2026

Uh oh!

bito-code-review Bot commented Apr 6, 2026 •

edited

Loading

Code Review Agent Run #2ee983

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

michael-s-molina commented Apr 6, 2026

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

bito-code-review Bot commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #754863

Uh oh!

codecov Bot commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

michael-s-molina commented Apr 6, 2026

Uh oh!

bito-code-review Bot commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #2ee983

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bito-code-review Bot commented Apr 6, 2026 •

edited

Loading

codecov Bot commented Apr 6, 2026 •

edited

Loading

bito-code-review Bot commented Apr 6, 2026 •

edited

Loading