fix(deps): revert simple-zstd from 2.1.0 back to 1.4.2#39139
fix(deps): revert simple-zstd from 2.1.0 back to 1.4.2#39139michael-s-molina merged 1 commit intoapache:masterfrom
Conversation
…t-frontend Reverts apache#38662. The v2 bump introduced breaking API changes that caused npm run dev-server to stop working. Even with the fixes in apache#39138 the application was still freezing. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Bito Automatic Review Skipped - Files Excluded |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #39139 +/- ##
=======================================
Coverage 64.52% 64.52%
=======================================
Files 2536 2536
Lines 131208 131208
Branches 30457 30457
=======================================
Hits 84661 84661
Misses 45084 45084
Partials 1463 1463
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| "rison": "^0.1.1", | ||
| "scroll-into-view-if-needed": "^3.1.0", | ||
| "simple-zstd": "^2.1.0", | ||
| "simple-zstd": "^1.4.2", |
There was a problem hiding this comment.
@michael-s-molina in the future, we should probably leave a comment when we revert packages to a lower version. I can see dependabot bumping this, someone not knowing and approving this. I'm guessing I could have easily been an approver of this if it was a dependabot bump
|
Thanks @michael-s-molina for covering me on this one! I'll probably need to add some test harness for safe upgrade when it comes to external deps like |
SUMMARY
Reverts #38662.
The v2 bump introduced breaking API changes (
ZSTDDecompressrenamed todecompress, now async) that causednpm run dev-serverto stop working. Even with the fixes attempted in #39138, the application was still freezing when navigating between pages.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
npm ciinsuperset-frontend/npm run dev-serverADDITIONAL INFORMATION