Skip to content

fix(deps): revert simple-zstd from 2.1.0 back to 1.4.2#39139

Merged
michael-s-molina merged 1 commit intoapache:masterfrom
michael-s-molina:revert/simple-zstd-bump
Apr 6, 2026
Merged

fix(deps): revert simple-zstd from 2.1.0 back to 1.4.2#39139
michael-s-molina merged 1 commit intoapache:masterfrom
michael-s-molina:revert/simple-zstd-bump

Conversation

@michael-s-molina
Copy link
Copy Markdown
Member

SUMMARY

Reverts #38662.

The v2 bump introduced breaking API changes (ZSTDDecompress renamed to decompress, now async) that caused npm run dev-server to stop working. Even with the fixes attempted in #39138, the application was still freezing when navigating between pages.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

  1. Run npm ci in superset-frontend/
  2. Start the Superset backend
  3. Run npm run dev-server
  4. Navigate between pages — no freezing or proxy errors

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

…t-frontend

Reverts apache#38662. The v2 bump introduced breaking API changes
that caused npm run dev-server to stop working. Even with the fixes in
apache#39138 the application was still freezing.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@bito-code-review
Copy link
Copy Markdown
Contributor

bito-code-review Bot commented Apr 6, 2026

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at evan@preset.io.

@michael-s-molina michael-s-molina changed the title revert(deps): revert simple-zstd from 2.1.0 back to 1.4.2 in /superset-frontend fix(deps): revert simple-zstd from 2.1.0 back to 1.4.2 in /superset-frontend Apr 6, 2026
@michael-s-molina michael-s-molina changed the title fix(deps): revert simple-zstd from 2.1.0 back to 1.4.2 in /superset-frontend fix(deps): revert simple-zstd from 2.1.0 back to 1.4.2 Apr 6, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.52%. Comparing base (d796543) to head (904c861).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #39139   +/-   ##
=======================================
  Coverage   64.52%   64.52%           
=======================================
  Files        2536     2536           
  Lines      131208   131208           
  Branches    30457    30457           
=======================================
  Hits        84661    84661           
  Misses      45084    45084           
  Partials     1463     1463           
Flag Coverage Δ
javascript 66.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@michael-s-molina michael-s-molina merged commit a3dfbd7 into apache:master Apr 6, 2026
77 of 78 checks passed
"rison": "^0.1.1",
"scroll-into-view-if-needed": "^3.1.0",
"simple-zstd": "^2.1.0",
"simple-zstd": "^1.4.2",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-s-molina in the future, we should probably leave a comment when we revert packages to a lower version. I can see dependabot bumping this, someone not knowing and approving this. I'm guessing I could have easily been an approver of this if it was a dependabot bump

@hainenber
Copy link
Copy Markdown
Contributor

Thanks @michael-s-molina for covering me on this one! I'll probably need to add some test harness for safe upgrade when it comes to external deps like zstd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants