Skip to content

fix(slack): fix indented triple-quoted string in v1 API deprecation warning - #41393

Merged
eschutho merged 1 commit into
apache:masterfrom
eschutho:fix/slack-deprecation-warning-formatting
Jun 25, 2026
Merged

fix(slack): fix indented triple-quoted string in v1 API deprecation warning#41393
eschutho merged 1 commit into
apache:masterfrom
eschutho:fix/slack-deprecation-warning-formatting

Conversation

@eschutho

Copy link
Copy Markdown
Member

What was the deprecation warning?

should_use_v2_api() in superset/utils/slack.py logged a warning using a triple-quoted string. Because the string was written inside an indented except block, Python included the code-level indentation in the message — each continuation line got 12 leading spaces. Production logs showed:

Your current Slack scopes are missing `channels:read`. Please add
            this to your Slack app in order to continue using the v1 API. Support
            for the old Slack API will be removed in Superset version 6.0.0.

What was changed?

Replaced the triple-quoted string with adjacent string literals so the message renders as a single clean line:

Your current Slack scopes are missing `channels:read`. Please add this to your Slack app in order to continue using the v1 API. Support for the old Slack API will be removed in Superset version 6.0.0.

No logic change. Same words, no whitespace artifact.

No-behavior-change note

This is a log message formatting fix only. should_use_v2_api() returns exactly the same values in all paths. No imports added or removed.

Test plan

  • Confirm no pre-commit failures: pre-commit run --files superset/utils/slack.py
  • Confirm the message logs cleanly by checking the logger.warning call manually or via existing Slack notification tests

…arning

The warning message in should_use_v2_api() used a triple-quoted string
that included the function body's indentation in the log output. Replace
with adjacent string literals so the message logs on a single clean line.
@bito-code-review

bito-code-review Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Code Review Agent Run #3e261e

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: ddc2492..ddc2492
    • superset/utils/slack.py
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@eschutho
eschutho requested a review from betodealmeida June 24, 2026 16:12
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.41%. Comparing base (3261d10) to head (ddc2492).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #41393   +/-   ##
=======================================
  Coverage   64.41%   64.41%           
=======================================
  Files        2654     2654           
  Lines      145386   145386           
  Branches    33557    33557           
=======================================
  Hits        93653    93653           
  Misses      50034    50034           
  Partials     1699     1699           
Flag Coverage Δ
hive 39.23% <ø> (ø)
mysql 58.00% <ø> (ø)
postgres 58.06% <ø> (ø)
presto 40.81% <ø> (ø)
python 59.50% <ø> (ø)
sqlite 57.72% <ø> (ø)
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rusackas rusackas added the review:checkpoint Last PR reviewed during the daily review standup label Jun 24, 2026
@eschutho
eschutho merged commit baca76e into apache:master Jun 25, 2026
63 checks passed
@rusackas rusackas removed the review:checkpoint Last PR reviewed during the daily review standup label Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants