Skip to content

chore(ci): correct actions/cache version comment to match pinned SHA - #41483

Merged
hainenber merged 1 commit into
masterfrom
chore/ci-cache-ref-version-comment
Jun 28, 2026
Merged

chore(ci): correct actions/cache version comment to match pinned SHA#41483
hainenber merged 1 commit into
masterfrom
chore/ci-cache-ref-version-comment

Conversation

@rusackas

Copy link
Copy Markdown
Member

SUMMARY

The actions/cache step is pinned to SHA 27d5ce7f107fe9357f9df03efb73ab90386fccae, which actually corresponds to release v5.0.5, but the inline comment read # v5. zizmor's ref-version-mismatch rule flags this discrepancy because the human-readable comment no longer truthfully reflects the pinned ref.

This updates the comment to the accurate # v5.0.5 in both pre-commit.yml and release.yml (all three occurrences use the same SHA). No behavior change — the SHA pin is unchanged; only the trailing comment is corrected to be truthful.

Resolves code-scanning alert #2551 (zizmor/ref-version-mismatch).

BEFORE/AFTER

Before:

uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5

After:

uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5

TESTING INSTRUCTIONS

pre-commit run zizmor --files .github/workflows/pre-commit.yml .github/workflows/release.yml passes.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

🤖 Generated with Claude Code

The pinned SHA 27d5ce7 actually corresponds to actions/cache v5.0.5,
but the inline comment read "# v5". zizmor's ref-version-mismatch rule
flags this discrepancy. Update the comment to the truthful version.

Resolves code-scanning alert #2551

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@dosubot dosubot Bot added the github_actions Pull requests that update GitHub Actions code label Jun 27, 2026
@bito-code-review

bito-code-review Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at evan@preset.io.

@hainenber
hainenber merged commit 78dd400 into master Jun 28, 2026
53 checks passed
@hainenber
hainenber deleted the chore/ci-cache-ref-version-comment branch June 28, 2026 03:56
shantanukhond pushed a commit to shantanukhond/superset that referenced this pull request Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants