fix(mcp): document select_columns valid fields and URL scheme for preview tools - #41595
Merged
aminghadersohi merged 1 commit intoJul 1, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #41595 +/- ##
==========================================
- Coverage 64.43% 64.41% -0.02%
==========================================
Files 2667 2668 +1
Lines 147073 147220 +147
Branches 33939 33954 +15
==========================================
+ Hits 94765 94838 +73
- Misses 50593 50666 +73
- Partials 1715 1716 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Bito Automatic Review Skipped – PR Already Merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_dataset_info/select_columns: The field description did not list which values are valid. Updated bothGetDatasetInfoRequest.select_columnsand the function docstring to enumerate the default set and all additional available field names so the model can construct a working call from the schema alone.URL scheme for preview/link tools:
get_chart_preview,generate_explore_link,update_chart_preview, andopen_sql_lab_with_contextdid not document the URL scheme of their returned URLs. Added a note that the scheme mirrors the configured instance URL (HTTPS in production/staging, HTTP in local development). Also updatedURLPreview.preview_urlfield description.Testing