fix(embedded): register AG Grid modules for view-as-table modal

[durgaprasadml]

SUMMARY

Fixes an issue where the “View as table” action fails in Embedded Dashboard mode with the following error:

AG Grid: error #272 No AG Grid modules are registered!

The embedded dashboard application uses a separate bootstrap entrypoint from the main Superset application. While the main application initializes AG Grid modules during startup, the embedded bootstrap flow did not initialize them before AG Grid components were mounted.

This change ensures AG Grid modules are initialized during embedded application startup, aligning the embedded initialization flow with the main application and allowing the “View as table” modal to render correctly inside embedded dashboards.

Fixes #41630.

⸻

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

• Clicking View as table inside an embedded dashboard opens an empty modal.
• The browser console displays:
  • AG Grid: error + button on Slice list view redirects to Table view with alert #272 No AG Grid modules are registered!

After

• Clicking View as table correctly renders the table inside the modal.
• No AG Grid registration errors appear in the browser console.

⸻

TESTING INSTRUCTIONS

1. Enable embedded dashboards by setting:
   EMBEDDED_SUPERSET = True
2. Embed a dashboard using the Embedded SDK.
3. Open the chart actions menu (...) on any chart.
4. Click View as table.
5. Verify the table renders successfully.
6. Verify no AG Grid registration errors appear in the browser console.
7. Verify the main Superset dashboard experience remains unchanged.

Additionally:

• Added regression coverage to verify AG Grid modules are initialized during embedded application bootstrap.

[bito-code-review]

Code Review Agent Run #a11336

Actionable Suggestions - 0

Additional Suggestions - 1

• superset-frontend/src/embedded/index.test.tsx - 1

  • Inconsistent test pattern · Line 15-15
    Please switch to a single top-level `test()` call instead of using `describe()`/`it()`, aligning this file's structure with the existing embedded tests.

Review Details

• Files reviewed - 2 · Commit Range: 5eb84a7..5eb84a7

  • superset-frontend/src/embedded/index.test.tsx
  • superset-frontend/src/embedded/index.tsx
• Files skipped - 1

  • PR_DESCRIPTION_DRAFT.md - Reason: Filter setting
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.47%. Comparing base (b3c709b) to head (5a73c2e).
⚠️ Report is 104 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #41632      +/-   ##
==========================================
+ Coverage   64.45%   64.47%   +0.02%     
==========================================
  Files        2670     2670              
  Lines      147343   147344       +1     
  Branches    33988    33988              
==========================================
+ Hits        94966    95002      +36     
+ Misses      50650    50615      -35     
  Partials     1727     1727              

Flag	Coverage Δ
javascript	69.20% <100.00%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bito-code-review]

Code Review Agent Run #08892f

Actionable Suggestions - 0

Review Details

• Files reviewed - 2 · Commit Range: 825160c..5a73c2e

  • superset-frontend/src/embedded/index.test.tsx
  • superset-frontend/src/embedded/index.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[rusackas]

Thanks @durgaprasadml! Confirmed the main app registers AG Grid modules in App.tsx while the embedded entrypoint never did, so this seems like the right fix. Thanks for the regression test, too. LGTM, approving, and I'll merge soon if there's no objection.