Skip to content

feat(i18n): backfill new safe-link strings in de/lv/fi (AI-generated, needs review) - #41646

Merged
sadpandajoe merged 1 commit into
masterfrom
chore/i18n-newstrings-topup
Jul 2, 2026
Merged

feat(i18n): backfill new safe-link strings in de/lv/fi (AI-generated, needs review)#41646
sadpandajoe merged 1 commit into
masterfrom
chore/i18n-newstrings-topup

Conversation

@rusackas

@rusackas rusackas commented Jul 1, 2026

Copy link
Copy Markdown
Member

SUMMARY

#39925 added two new user-facing strings — "Unsafe link blocked" and "This link cannot be followed because its address is unsafe." — to every message catalog. The German (#41608), Latvian (#41612), and Finnish (#41613) backfill PRs had already merged by then, so these two strings landed untranslated in those three catalogs.

This small follow-up fills them (6 entries total) via scripts/translations/backfill_po.py, marked #, fuzzy with the usual attribution comment for human review — consistent with the rest of the i18n backfill sweep.

The other in-flight backfill PRs (#41609 es, #41640 sk, #41641 th, #41645 uk) already include these strings, since they were rebased after #39925 landed.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Translation catalogs only — no layout or behavior change. Note: the frontend po2json --fuzzy build includes these fuzzy strings, so they render in the UI once the frontend is rebuilt; the backend excludes them (English fallback).

TESTING INSTRUCTIONS

  • pybabel compile -d superset/translations -l de -l lv -l fi succeeds.
  • de/lv/fi speakers: review the #, fuzzy entries and de-fuzz once confirmed.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
  • Introduces new feature or API
  • Removes existing feature or API

… needs review)

PR #39925 added two new user-facing strings ("Unsafe link blocked" and "This
link cannot be followed because its address is unsafe.") to every catalog. The
German, Latvian, and Finnish backfill PRs (#41608, #41612, #41613) had already
merged by then, so those two strings landed untranslated in those three
catalogs. This fills them via scripts/translations/backfill_po.py, marked
`#, fuzzy` for human review like the rest of the AI backfill.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@bito-code-review

bito-code-review Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Code Review Agent Run #2b1920

Actionable Suggestions - 0
Review Details
  • Files reviewed - 3 · Commit Range: 1054acd..1054acd
    • superset/translations/de/LC_MESSAGES/messages.po
    • superset/translations/fi/LC_MESSAGES/messages.po
    • superset/translations/lv/LC_MESSAGES/messages.po
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@dosubot dosubot Bot added i18n:german Translation related to German language i18n:latvian labels Jul 1, 2026
@github-actions github-actions Bot added the i18n Namespace | Anything related to localization label Jul 1, 2026
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.55%. Comparing base (8be255d) to head (1054acd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #41646      +/-   ##
==========================================
- Coverage   64.55%   64.55%   -0.01%     
==========================================
  Files        2673     2673              
  Lines      147634   147634              
  Branches    34090    34090              
==========================================
- Hits        95308    95301       -7     
- Misses      50597    50601       +4     
- Partials     1729     1732       +3     
Flag Coverage Δ
hive 39.06% <ø> (ø)
mysql 57.68% <ø> (ø)
postgres 57.74% <ø> (-0.01%) ⬇️
presto 40.61% <ø> (ø)
python 59.15% <ø> (-0.01%) ⬇️
sqlite 57.33% <ø> (ø)
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sadpandajoe
sadpandajoe merged commit 661d362 into master Jul 2, 2026
66 checks passed
@sadpandajoe
sadpandajoe deleted the chore/i18n-newstrings-topup branch July 2, 2026 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n:german Translation related to German language i18n:latvian i18n Namespace | Anything related to localization preset-io size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants