Skip to content

test(ci): stabilize master checks - #41650

Merged
rusackas merged 1 commit into
masterfrom
codex/fix-create-dataset-e2e-timeout
Jul 2, 2026
Merged

test(ci): stabilize master checks#41650
rusackas merged 1 commit into
masterfrom
codex/fix-create-dataset-e2e-timeout

Conversation

@sadpandajoe

Copy link
Copy Markdown
Member

SUMMARY

Fixes the current master CI regressions observed across recent master runs:

  • Update stale unit-test patches to target the real module objects instead of package exports that shadow submodules with function objects.
  • Give the dataset creation Playwright spec the existing slow-test timeout budget, matching the work it performs in CI.
  • Type intentional invalid semantic-layer test inputs as Any so mypy accepts the negative cases without changing test behavior.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Not applicable; this is a test-only CI stabilization change.

TESTING INSTRUCTIONS

  • PATH=/Users/joeli/.nvm/versions/node/v24.16.0/bin:$PATH pre-commit run --files superset-frontend/playwright/tests/dataset/create-dataset.spec.ts tests/unit_tests/semantic_layers/mapper_test.py tests/unit_tests/mcp_service/dashboard/tool/test_get_dashboard_datasets.py tests/unit_tests/pandas_postprocessing/test_prophet.py
  • PATH=/Users/joeli/.nvm/versions/node/v24.16.0/bin:$PATH pre-commit run
  • pytest tests/unit_tests/mcp_service/dashboard/tool/test_get_dashboard_datasets.py tests/unit_tests/pandas_postprocessing/test_prophet.py::test_prophet_fit_error tests/unit_tests/semantic_layers/mapper_test.py -q was attempted locally, but this worktree fails during test collection before these tests run because local sqlglot/Dremio imports raise TypeError: Cannot create a consistent method resolution order (MRO) for bases Expression, Func.
  • pre-commit run --all-files was attempted locally; it is blocked in this environment by docs/helm/frontend build prerequisites and an unrelated all-files ruff C901 finding in superset/mcp_service/sql_lab/tool/execute_sql.py. The latest master pre-commit checks Action is green, so CI remains the source of truth for the full matrix.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.60%. Comparing base (8bf3933) to head (7d1497e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #41650   +/-   ##
=======================================
  Coverage   64.60%   64.60%           
=======================================
  Files        2684     2684           
  Lines      148283   148283           
  Branches    34158    34158           
=======================================
  Hits        95796    95796           
  Misses      50742    50742           
  Partials     1745     1745           
Flag Coverage Δ
hive 39.23% <ø> (ø)
javascript 69.36% <ø> (ø)
mysql 57.83% <ø> (ø)
postgres 57.89% <ø> (ø)
presto 40.76% <ø> (ø)
python 59.28% <ø> (ø)
sqlite 57.47% <ø> (ø)
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sadpandajoe
sadpandajoe marked this pull request as ready for review July 2, 2026 19:07
@sadpandajoe
sadpandajoe force-pushed the codex/fix-create-dataset-e2e-timeout branch from cbbf7e4 to 7d1497e Compare July 2, 2026 20:41
@sadpandajoe sadpandajoe added the merge-if-green If approved and tests are green, please go ahead and merge it for me label Jul 2, 2026
@bito-code-review

bito-code-review Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Code Review Agent Run #8a2b14

Actionable Suggestions - 0
Review Details
  • Files reviewed - 4 · Commit Range: 7d1497e..7d1497e
    • superset-frontend/playwright/tests/dataset/create-dataset.spec.ts
    • tests/unit_tests/mcp_service/dashboard/tool/test_get_dashboard_datasets.py
    • tests/unit_tests/pandas_postprocessing/test_prophet.py
    • tests/unit_tests/semantic_layers/mapper_test.py
  • Files skipped - 0
  • Tools
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful
    • Eslint (Linter) - ✔︎ Successful
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@rusackas rusackas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU.

@rusackas
rusackas merged commit a308468 into master Jul 2, 2026
68 checks passed
@rusackas
rusackas deleted the codex/fix-create-dataset-e2e-timeout branch July 2, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-if-green If approved and tests are green, please go ahead and merge it for me review:draft size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants