Skip to content

chore(viz): drop the legacy- prefix from migrated chart plugin packages - #41751

Merged
rusackas merged 1 commit into
remove-legacy-viz-pipelinefrom
legacy-viz-phase3-renames
Jul 3, 2026
Merged

chore(viz): drop the legacy- prefix from migrated chart plugin packages#41751
rusackas merged 1 commit into
remove-legacy-viz-pipelinefrom
legacy-viz-phase3-renames

Conversation

@rusackas

@rusackas rusackas commented Jul 3, 2026

Copy link
Copy Markdown
Member

SUMMARY

Phase 3 of #41714 (targets remove-legacy-viz-pipeline): with every chart in these packages on the v1 chart data API, the directories and npm names drop the legacy- prefix.

  • legacy-plugin-chart-{calendar, chord, country-map, horizon, paired-t-test, parallel-coordinates, partition, rose, world-map}plugin-chart-*
  • legacy-preset-chart-nvd3preset-chart-nvd3 (Bullet and Time-series Period Pivot live on there; the other nvd3 charts were retargeted to ECharts)

References updated across package.json workspaces and the lockfile (which also carried stale entries for the long-gone legacy-preset-chart-deckgl), MainPreset imports, tsconfig path mappings + project references, webpack, the storybook-coverage script, custom-rule grandfather patterns (the renamed dirs keep their old color patterns/eager t() pending modernization), CODEOWNERS, dependabot config, docs, plugin READMEs, and story titles (out of the "Legacy Chart Plugins" group).

viz_type keys are untouched — no DB migration, saved charts are unaffected. Git tracks all moves as renames.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A — package renames only.

TESTING INSTRUCTIONS

  • npm install reconciles cleanly; zero legacy-plugin-chart/legacy-preset-chart references remain outside historical changelogs.
  • npm run test -- plugins/plugin-chart-chord plugins/plugin-chart-world-map plugins/preset-chart-nvd3 plugins/plugin-chart-partition — 93 tests pass under the new paths.
  • pre-commit run green.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
  • Introduces new feature or API
  • Removes existing feature or API

🤖 Generated with Claude Code

Every chart in these packages now uses the v1 chart data API, so the
directories and npm names lose their legacy- prefix:

- legacy-plugin-chart-{calendar,chord,country-map,horizon,
  paired-t-test,parallel-coordinates,partition,rose,world-map}
  -> plugin-chart-*
- legacy-preset-chart-nvd3 -> preset-chart-nvd3 (bullet and time_pivot
  survive there; the other nvd3 charts were retargeted to ECharts)

References updated across package.json workspaces and the lockfile
(which also carried stale entries for the long-gone
legacy-preset-chart-deckgl), MainPreset, tsconfig path mappings,
webpack, storybook coverage and custom-rule grandfather patterns,
CODEOWNERS, dependabot config and docs. Story titles move out of the
'Legacy Chart Plugins' group.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@bito-code-review

bito-code-review Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at evan@preset.io.

@github-actions github-actions Bot added doc Namespace | Anything related to documentation plugins dependencies:npm labels Jul 3, 2026
@netlify

netlify Bot commented Jul 3, 2026

Copy link
Copy Markdown

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 1dcecc5
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6a47e01235f4a20007ccf171
😎 Deploy Preview https://deploy-preview-41751--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (remove-legacy-viz-pipeline@b60cf4e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...lugins/plugin-chart-calendar/src/transformProps.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##             remove-legacy-viz-pipeline   #41751   +/-   ##
=============================================================
  Coverage                              ?   64.75%           
=============================================================
  Files                                 ?     2703           
  Lines                                 ?   149119           
  Branches                              ?    34483           
=============================================================
  Hits                                  ?    96560           
  Misses                                ?    50799           
  Partials                              ?     1760           
Flag Coverage Δ
hive 39.20% <ø> (?)
javascript 69.58% <66.66%> (?)
mysql 57.85% <ø> (?)
postgres 57.91% <ø> (?)
presto 40.75% <ø> (?)
python 59.30% <ø> (?)
sqlite 57.49% <ø> (?)
unit 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rusackas
rusackas merged commit 1cdd446 into remove-legacy-viz-pipeline Jul 3, 2026
59 checks passed
@rusackas
rusackas deleted the legacy-viz-phase3-renames branch July 3, 2026 16:36
rusackas added a commit that referenced this pull request Jul 7, 2026
…es (#41751)

Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 7, 2026
…es (#41751)

Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 8, 2026
…es (#41751)

Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 10, 2026
…es (#41751)

Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 13, 2026
…es (#41751)

Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 14, 2026
…es (#41751)

Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 15, 2026
…es (#41751)

Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 15, 2026
…es (#41751)

Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 16, 2026
…es (#41751)

Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 17, 2026
…es (#41751)

Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 20, 2026
…es (#41751)

Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 20, 2026
…es (#41751)

Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 20, 2026
…es (#41751)

Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 21, 2026
…es (#41751)

Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 21, 2026
…es (#41751)

Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 23, 2026
…es (#41751)

Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 27, 2026
…es (#41751)

Co-authored-by: Claude Code <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies:npm doc Namespace | Anything related to documentation frontend:refactor Related to refactoring the frontend plugins

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants