chore(viz): drop the legacy- prefix from migrated chart plugin packages - #41751
Conversation
Every chart in these packages now uses the v1 chart data API, so the
directories and npm names lose their legacy- prefix:
- legacy-plugin-chart-{calendar,chord,country-map,horizon,
paired-t-test,parallel-coordinates,partition,rose,world-map}
-> plugin-chart-*
- legacy-preset-chart-nvd3 -> preset-chart-nvd3 (bullet and time_pivot
survive there; the other nvd3 charts were retargeted to ECharts)
References updated across package.json workspaces and the lockfile
(which also carried stale entries for the long-gone
legacy-preset-chart-deckgl), MainPreset, tsconfig path mappings,
webpack, storybook coverage and custom-rule grandfather patterns,
CODEOWNERS, dependabot config and docs. Story titles move out of the
'Legacy Chart Plugins' group.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Bito Automatic Review Skipped - Branch Excluded |
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## remove-legacy-viz-pipeline #41751 +/- ##
=============================================================
Coverage ? 64.75%
=============================================================
Files ? 2703
Lines ? 149119
Branches ? 34483
=============================================================
Hits ? 96560
Misses ? 50799
Partials ? 1760
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…es (#41751) Co-authored-by: Claude Code <noreply@anthropic.com>
…es (#41751) Co-authored-by: Claude Code <noreply@anthropic.com>
…es (#41751) Co-authored-by: Claude Code <noreply@anthropic.com>
…es (#41751) Co-authored-by: Claude Code <noreply@anthropic.com>
…es (#41751) Co-authored-by: Claude Code <noreply@anthropic.com>
…es (#41751) Co-authored-by: Claude Code <noreply@anthropic.com>
…es (#41751) Co-authored-by: Claude Code <noreply@anthropic.com>
…es (#41751) Co-authored-by: Claude Code <noreply@anthropic.com>
…es (#41751) Co-authored-by: Claude Code <noreply@anthropic.com>
…es (#41751) Co-authored-by: Claude Code <noreply@anthropic.com>
…es (#41751) Co-authored-by: Claude Code <noreply@anthropic.com>
…es (#41751) Co-authored-by: Claude Code <noreply@anthropic.com>
…es (#41751) Co-authored-by: Claude Code <noreply@anthropic.com>
…es (#41751) Co-authored-by: Claude Code <noreply@anthropic.com>
…es (#41751) Co-authored-by: Claude Code <noreply@anthropic.com>
…es (#41751) Co-authored-by: Claude Code <noreply@anthropic.com>
…es (#41751) Co-authored-by: Claude Code <noreply@anthropic.com>
SUMMARY
Phase 3 of #41714 (targets
remove-legacy-viz-pipeline): with every chart in these packages on the v1 chart data API, the directories and npm names drop thelegacy-prefix.legacy-plugin-chart-{calendar, chord, country-map, horizon, paired-t-test, parallel-coordinates, partition, rose, world-map}→plugin-chart-*legacy-preset-chart-nvd3→preset-chart-nvd3(Bullet and Time-series Period Pivot live on there; the other nvd3 charts were retargeted to ECharts)References updated across
package.jsonworkspaces and the lockfile (which also carried stale entries for the long-gonelegacy-preset-chart-deckgl), MainPreset imports, tsconfig path mappings + project references, webpack, the storybook-coverage script, custom-rule grandfather patterns (the renamed dirs keep their old color patterns/eagert()pending modernization), CODEOWNERS, dependabot config, docs, plugin READMEs, and story titles (out of the "Legacy Chart Plugins" group).viz_typekeys are untouched — no DB migration, saved charts are unaffected. Git tracks all moves as renames.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — package renames only.
TESTING INSTRUCTIONS
npm installreconciles cleanly; zerolegacy-plugin-chart/legacy-preset-chartreferences remain outside historical changelogs.npm run test -- plugins/plugin-chart-chord plugins/plugin-chart-world-map plugins/preset-chart-nvd3 plugins/plugin-chart-partition— 93 tests pass under the new paths.pre-commit rungreen.ADDITIONAL INFORMATION
🤖 Generated with Claude Code