Skip to content

fix(a11y): add aria-label to CRON schedule input#41769

Merged
eschutho merged 2 commits into
masterfrom
fix/a11y-cron-schedule-input-label
Jul 5, 2026
Merged

fix(a11y): add aria-label to CRON schedule input#41769
eschutho merged 2 commits into
masterfrom
fix/a11y-cron-schedule-input-label

Conversation

@eschutho

@eschutho eschutho commented Jul 4, 2026

Copy link
Copy Markdown
Member

WCAG rule

2.1 SC 1.3.1 (Info and Relationships) / 3.3.2 (Labels or Instructions) — Level A.

What changed

The CRON expression text input in AlertReportCronScheduler (shown when a user picks "CRON Schedule" for an alert/report) had no aria-label, aria-labelledby, or associated <label>. Its only hint was a placeholder (t('CRON expression')) plus a visually adjacent but unassociated <div className="control-label"> reading "Schedule". Screen reader users tabbing into the field heard no accessible name at all.

Added aria-label={t('Schedule')} to the <Input>, matching the naming convention already used by the sibling Select above it (ariaLabel={t('Schedule type')}, mirroring its own adjacent visible label).

Behavior

No visual or functional change — this only adds an accessible name for assistive technology.

Test plan

  1. Open Alerts & Reports → create/edit an alert → in the "Schedule" section, switch schedule type to "CRON Schedule".
  2. Tab to the CRON expression input with a screen reader running (e.g. VoiceOver/NVDA).
  3. Verify the announced label is "Schedule" (previously: no accessible name announced, or generic "edit text").

WCAG 2.1 SC 1.3.1/3.3.2 — Level A.
@dosubot dosubot Bot added alert-reports Namespace | Anything related to the Alert & Reports feature design:accessibility Related to accessibility standards labels Jul 4, 2026
@bito-code-review

bito-code-review Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Code Review Agent Run #8b332c

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: ebdfd2b..ebdfd2b
    • superset-frontend/src/features/alerts/components/AlertReportCronScheduler.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@eschutho eschutho requested a review from rebenitez1802 July 4, 2026 10:14
@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.66%. Comparing base (687fafd) to head (ed82acf).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #41769   +/-   ##
=======================================
  Coverage   64.66%   64.66%           
=======================================
  Files        2685     2685           
  Lines      148593   148593           
  Branches    34282    34282           
=======================================
  Hits        96088    96088           
  Misses      50740    50740           
  Partials     1765     1765           
Flag Coverage Δ
javascript 69.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eschutho eschutho merged commit 7cdfe3f into master Jul 5, 2026
66 checks passed
@eschutho eschutho deleted the fix/a11y-cron-schedule-input-label branch July 5, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

alert-reports Namespace | Anything related to the Alert & Reports feature design:accessibility Related to accessibility standards size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants