fix(a11y): add aria-label to CRON schedule input#41769
Conversation
WCAG 2.1 SC 1.3.1/3.3.2 — Level A.
Code Review Agent Run #8b332cActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #41769 +/- ##
=======================================
Coverage 64.66% 64.66%
=======================================
Files 2685 2685
Lines 148593 148593
Branches 34282 34282
=======================================
Hits 96088 96088
Misses 50740 50740
Partials 1765 1765
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
WCAG rule
2.1 SC 1.3.1 (Info and Relationships) / 3.3.2 (Labels or Instructions) — Level A.
What changed
The CRON expression text input in
AlertReportCronScheduler(shown when a user picks "CRON Schedule" for an alert/report) had noaria-label,aria-labelledby, or associated<label>. Its only hint was a placeholder (t('CRON expression')) plus a visually adjacent but unassociated<div className="control-label">reading "Schedule". Screen reader users tabbing into the field heard no accessible name at all.Added
aria-label={t('Schedule')}to the<Input>, matching the naming convention already used by the siblingSelectabove it (ariaLabel={t('Schedule type')}, mirroring its own adjacent visible label).Behavior
No visual or functional change — this only adds an accessible name for assistive technology.
Test plan