test broken by annyzhu713 · Pull Request #41775 · apache/superset

annyzhu713 · 2026-07-05T01:25:52Z

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

bito-code-review · 2026-07-05T01:26:03Z

Code Review Agent Run #0f42a3

Actionable Suggestions - 0

Filtered by Review Rules

Bito filtered these suggestions based on rules created automatically for your feedback. Manage rules.

superset/utils/core.py - 2
- Type/docstring mismatch · Line 420-420
- Runtime crash on None input · Line 444-445

Review Details

Files reviewed - 1 · Commit Range: 4a5e857..4a5e857
- superset/utils/core.py
Files skipped - 0
Tools
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

netlify · 2026-07-05T01:27:31Z

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	`b32a37f`
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/6a49b3a033de6800088017ea
😎 Deploy Preview	https://deploy-preview-41775--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

codeant-ai-for-open-source · 2026-07-05T01:29:55Z



-def cast_to_num(value: float | int | str | None) -> float | int | None:
+def cast_to_num(value: float | int | str) -> float | int | None:


Suggestion: This signature change drops None from the accepted input type, but the function’s documented/tested contract still includes None and the body calls value.isdigit() without a null guard. Passing None now will raise an exception instead of returning None, so restore None in the accepted type and keep an explicit None early return. [api mismatch]

Severity Level: Critical 🚨

- ❌ Integration test `test_cast_to_num` fails due to AttributeError. - ⚠️ Numeric filter conversion in helpers.py uses cast_to_num. - ⚠️ Function docs and doctests still include None input.

Steps of Reproduction ✅

1. Run the integration test suite, specifically `test_cast_to_num` in `tests/integration_tests/utils_tests.py:404-410`, which imports `cast_to_num` from `superset.utils.core` at lines 42-46. 2. The test calls `cast_to_num(None)` (see `tests/integration_tests/utils_tests.py:409`), expecting the function to return `None` as asserted in the test and documented by the doctest examples in `superset/utils/core.py:56-59`. 3. The call reaches `cast_to_num` defined in `superset/utils/core.py:41-72`, where the signature is `def cast_to_num(value: float | int | str) -> float | int | None:` and the implementation executes: - `if isinstance(value, (int, float)):` at line 65, which is false for `None`, - then `if value.isdigit():` at line 67. 4. Because `value` is `None`, `value.isdigit()` raises `AttributeError: 'NoneType' object has no attribute 'isdigit'`, causing the test and any real caller passing `None` (such as numeric filter handling in `superset/models/helpers.py:2658-2673` which delegates to `utils.cast_to_num(value)`) to fail unexpectedly instead of returning `None` as per the documented contract.

(Use Cmd/Ctrl + Click for best experience)

Prompt for AI Agent 🤖

This is a comment left during a code review. **Path:** superset/utils/core.py **Line:** 420:420 **Comment:** *Api Mismatch: This signature change drops `None` from the accepted input type, but the function’s documented/tested contract still includes `None` and the body calls `value.isdigit()` without a null guard. Passing `None` now will raise an exception instead of returning `None`, so restore `None` in the accepted type and keep an explicit `None` early return. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix

👍 | 👎

bito-code-review · 2026-07-05T01:30:05Z

The flagged issue is correct. The removal of None from the type hint and the deletion of the if value is None check causes an AttributeError when None is passed, as value.isdigit() is called without a null guard. To resolve this, restore None to the type hint and re-add the early return for None values.

superset/utils/core.py

def cast_to_num(value: float | int | str | None) -> float | int | None:
    # ... (docstring)
    if value is None:
        return None
    if isinstance(value, (int, float)):
        return value
    if value.isdigit():

bito-code-review · 2026-07-05T04:36:04Z

Code Review Agent Run #70397a

Actionable Suggestions - 0

Filtered by Review Rules

Bito filtered these suggestions based on rules created automatically for your feedback. Manage rules.

superset/utils/core.py - 1
- Runtime AttributeError on None · Line 444-444

Review Details

Files reviewed - 1 · Commit Range: b32a37f..b32a37f
- superset/utils/core.py
Files skipped - 0
Tools
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

pull-request-size Bot added the size/XS label Jul 5, 2026

codeant-ai-for-open-source Bot reviewed Jul 5, 2026

View reviewed changes

test broken

b32a37f

annyzhu713 force-pushed the test-demo branch from 4a5e857 to b32a37f Compare July 5, 2026 01:30

annyzhu713 closed this Jul 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test broken#41775

test broken#41775
annyzhu713 wants to merge 1 commit into
apache:masterfrom
annyzhu713:test-demo

annyzhu713 commented Jul 5, 2026

Uh oh!

bito-code-review Bot commented Jul 5, 2026 •

edited

Loading

Code Review Agent Run #0f42a3

Uh oh!

netlify Bot commented Jul 5, 2026 •

edited

Loading

Uh oh!

codeant-ai-for-open-source Bot Jul 5, 2026

Uh oh!

bito-code-review Bot commented Jul 5, 2026

Uh oh!

bito-code-review Bot commented Jul 5, 2026 •

edited

Loading

Code Review Agent Run #70397a

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant



		def cast_to_num(value: float \| int \| str \| None) -> float \| int \| None:
		def cast_to_num(value: float \| int \| str) -> float \| int \| None:

Uh oh!

Conversation

annyzhu713 commented Jul 5, 2026

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

bito-code-review Bot commented Jul 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #0f42a3

Uh oh!

netlify Bot commented Jul 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for superset-docs-preview ready!

Uh oh!

codeant-ai-for-open-source Bot Jul 5, 2026

Choose a reason for hiding this comment

Uh oh!

bito-code-review Bot commented Jul 5, 2026

Uh oh!

bito-code-review Bot commented Jul 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #70397a

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

bito-code-review Bot commented Jul 5, 2026 •

edited

Loading

netlify Bot commented Jul 5, 2026 •

edited

Loading

bito-code-review Bot commented Jul 5, 2026 •

edited

Loading