test(async-queries): prove OAuth2RedirectError survives async chart queries

[rusackas]

SUMMARY

Test-only PR that proves issue #39096 is already fixed on master, and closes it.

closes #39096

The issue reported that with GLOBAL_ASYNC_QUERIES enabled, an OAuth2RedirectError raised while loading chart data (e.g. Trino + Keycloak OAuth2) was caught by the generic Exception handler in load_chart_data_into_cache and flattened to a plain {"message": "You don't have permission to access the data."}, losing the structured payload (url, tab_id, redirect_uri) the frontend needs to render the OAuth2 banner.

That code path has since been fixed:

• fix: Implement SIP-40 error styles for GAQ #36596 added SIP-40 structured-error extraction to load_chart_data_into_cache (the exact handler quoted in the issue), so any SupersetErrorException — including OAuth2RedirectError, which subclasses it — is serialized via dataclasses.asdict(ex.error) with its full error_type/level/extra payload.
• fix(OAuth2): Support OAuth2 exception with legacy endpoint #39897 extended the same treatment to the legacy load_explore_json_into_cache path and added an OAuth2-specific test there.

What was still missing is a regression test for the issue's exact scenario: OAuth2RedirectError raised by ChartDataCommand.run inside load_chart_data_into_cache. The existing chart-path tests only cover a generic SupersetErrorException, and the OAuth2-specific test from #39897 only covers the explore-json path. This PR adds that complementary unit test, which asserts the async job is updated with the structured OAUTH2_REDIRECT envelope (including the url/tab_id/redirect_uri extras) rather than the flattened permission message. The test passes on current master, confirming the reported behavior is resolved and guarding against regression.

No production code is changed.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A (test-only change)

TESTING INSTRUCTIONS

python -m pytest tests/unit_tests/tasks/test_async_queries.py -x -q

All tests in the module pass, including the new test_load_chart_data_into_cache_preserves_oauth2_redirect_error.

ADDITIONAL INFORMATION

• Has associated issue: closes OAuth2RedirectError lost in async chart queries (GLOBAL_ASYNC_QUERIES) #39096
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

🤖 Generated with Claude Code

[bito-code-review]

Code Review Agent Run #2cd37e

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: 8183dd7..8183dd7

  • tests/unit_tests/tasks/test_async_queries.py
• Files skipped - 0
• Tools

  • MyPy (Static Code Analysis) - ✔︎ Successful
  • Astral Ruff (Static Code Analysis) - ✔︎ Successful
  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.77%. Comparing base (9e50d9e) to head (8183dd7).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #41839      +/-   ##
==========================================
- Coverage   64.78%   64.77%   -0.01%     
==========================================
  Files        2689     2689              
  Lines      148936   148936              
  Branches    34365    34365              
==========================================
- Hits        96481    96474       -7     
- Misses      50690    50694       +4     
- Partials     1765     1768       +3     

Flag	Coverage Δ
hive	39.20% <ø> (ø)
mysql	57.86% <ø> (ø)
postgres	57.92% <ø> (-0.01%)	⬇️
presto	40.73% <ø> (ø)
python	59.32% <ø> (-0.01%)	⬇️
sqlite	57.50% <ø> (ø)
unit	100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.