fix(a11y): add aria-label to notification method remove button

[eschutho]

Summary

• NotificationMethod.tsx's per-method "remove" control (<span role="button" tabIndex={0}> wrapping a DeleteOutlined icon, shown when more than one notification method is configured on an Alert/Report) had no accessible name — screen reader users tabbing to it heard nothing identifying the control's purpose. The jsx-a11y/control-has-associated-label lint rule was being suppressed via an eslint-disable comment rather than fixed.
• Adds aria-label={t('Remove notification method')}, matching the existing 'Remove X' naming convention used elsewhere in the codebase (e.g. TableCatalog.tsx's 'Remove sheet', FilterTitleContainer.tsx's 'Remove filter'), and removes the now-unneeded eslint-disable comment.
• WCAG 2.1 SC 4.1.2 (Name, Role, Value) — Level A.
• Behavior is unchanged — purely an accessibility-name addition, no visual or functional change.

Test plan

• In the Alert/Report modal, add a second notification method (so the remove control renders)
• Tab to the remove ("X") control next to the second method
• Verify a screen reader (VoiceOver/NVDA) announces "Remove notification method, button" instead of no name
• Confirm clicking still removes the row as before

[bito-code-review]

Code Review Agent Run #6d761d

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: da800ad..da800ad

  • superset-frontend/src/features/alerts/components/NotificationMethod.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.78%. Comparing base (5e384f5) to head (da800ad).

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #41850      +/-   ##
==========================================
- Coverage   64.79%   64.78%   -0.01%     
==========================================
  Files        2691     2691              
  Lines      149012   149012              
  Branches    34391    34391              
==========================================
- Hits        96548    96542       -6     
- Misses      50695    50701       +6     
  Partials     1769     1769              

Flag	Coverage Δ
javascript	69.68% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[rusackas]

Is it worth just doing a big AI sweep of these things? I'll bet we can knock out a ton of 'em in one PR :D