Skip to content

fix(jinja): drill-to-detail respects remove_filter=True in Jinja templates#41934

Merged
michael-s-molina merged 2 commits into
apache:6.1from
luizotavio32:cherry-pick-39594-6.1
Jul 10, 2026
Merged

fix(jinja): drill-to-detail respects remove_filter=True in Jinja templates#41934
michael-s-molina merged 2 commits into
apache:6.1from
luizotavio32:cherry-pick-39594-6.1

Conversation

@luizotavio32

@luizotavio32 luizotavio32 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Cherry-picks #39594 into the 6.1 branch.

…lates (apache#39594)

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
@bito-code-review

bito-code-review Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at evan@preset.io.

@luizotavio32 luizotavio32 changed the title fix(jinja): drill-to-detail respects remove_filter=True in Jinja temp… fix(jinja): drill-to-detail respects remove_filter=True in Jinja templates Jul 10, 2026
@netlify

netlify Bot commented Jul 10, 2026

Copy link
Copy Markdown

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 682d6f5
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6a5104d97efdbd0008cc2fda
😎 Deploy Preview https://deploy-preview-41934--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 10.52632% with 17 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (6.1@b50d423). Learn more about missing BASE report.

Files with missing lines Patch % Lines
superset/jinja_context.py 10.52% 17 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             6.1   #41934   +/-   ##
======================================
  Coverage       ?   64.30%           
======================================
  Files          ?     2547           
  Lines          ?   132504           
  Branches       ?    30708           
======================================
  Hits           ?    85208           
  Misses         ?    45829           
  Partials       ?     1467           
Flag Coverage Δ
hive 39.94% <10.52%> (?)
mysql 60.48% <10.52%> (?)
postgres 60.55% <10.52%> (?)
presto 39.96% <10.52%> (?)
python 62.12% <10.52%> (?)
sqlite 60.19% <10.52%> (?)
unit 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@luizotavio32 luizotavio32 marked this pull request as ready for review July 10, 2026 19:13
@dosubot dosubot Bot added dashboard:drill-to-detail global:jinja Related to Jinja templating labels Jul 10, 2026
@michael-s-molina michael-s-molina merged commit c898341 into apache:6.1 Jul 10, 2026
108 checks passed
@luizotavio32 luizotavio32 deleted the cherry-pick-39594-6.1 branch July 10, 2026 20:01
michael-s-molina added a commit that referenced this pull request Jul 13, 2026
…lates (#41934)

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
(cherry picked from commit c898341)
kawcl pushed a commit to CarnegieLearningWeb/superset that referenced this pull request Jul 13, 2026
…lates (apache#41934)

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants